#10 add fixtures #13
Merged
#10 add fixtures #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
reviewed
May 17, 2024
tkilias
reviewed
May 17, 2024
tkilias
requested changes
May 17, 2024
Co-authored-by: Torsten Kilias <[email protected]>
* Added ip-whitelisting to fixture operational_saas_database_id * Verified fixture in test_operational_database
[run-slow-tests]
[run-slow-tests]
[run-slow-tests]
[run-slow-tests]
tkilias
reviewed
May 22, 2024
tkilias
reviewed
May 22, 2024
tkilias
reviewed
May 22, 2024
tkilias
reviewed
May 22, 2024
[run-slow-tests]
[run-slow-tests]
[run-slow-tests]
[run-slow-tests]
[run-slow-tests]
Co-authored-by: Torsten Kilias <[email protected]>
tkilias
reviewed
May 27, 2024
tkilias
reviewed
May 27, 2024
tkilias
reviewed
May 27, 2024
tkilias
reviewed
May 27, 2024
slow tests are now always executed
move developer instructions to Developer guide.
tkilias
approved these changes
May 27, 2024
Nicoretti
reviewed
Jun 4, 2024
Comment on lines
+11
to
+13
| rc = 0 | ||
| def run(command): | ||
| global rc |
There was a problem hiding this comment.
Why?
Please do not use globals, they are rarely a good idea. Only use them if you can justify it with a solid argument why there is no equivalent easy non-global alternative for the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10