#597: Move workflows into ci-build.yml #605
Conversation
project-keeper/src/main/java/com/exasol/projectkeeper/mavenrepo/MavenRepository.java
Show resolved
Hide resolved
...ect-keeper/src/main/java/com/exasol/projectkeeper/validators/files/FileTemplatesFactory.java
Show resolved
Hide resolved
| on: | ||
| schedule: | ||
| - cron: "0 5 * * 0" | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
Link checker workflow still required for cron job. Does not run for PR or branch changes any more.
There was a problem hiding this comment.
Can I still change the documentation of any project and verify if all links are valid before merging to main?
There was a problem hiding this comment.
Ah - I think ci-build-db-version-matrix.yml is the answer.
project-keeper/src/main/resources/templates/.github/workflows/ci-build-next-java.yml
Outdated
Show resolved
Hide resolved
| on: | ||
| schedule: | ||
| - cron: "0 5 * * 0" | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
Can I still change the documentation of any project and verify if all links are valid before merging to main?
| on: | ||
| schedule: | ||
| - cron: "0 5 * * 0" | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
Ah - I think ci-build-db-version-matrix.yml is the answer.
| @@ -110,6 +110,78 @@ jobs: | |||
| path: ${{ steps.build-pk-verify.outputs.release-artifacts }} | |||
| retention-days: 5 | |||
|
|
|||
| - name: Configure link check | |||
There was a problem hiding this comment.
Is there a way of avoiding the duplicate configuration of github-action-markdown-link-check?
There was a problem hiding this comment.
Yes, but I didn't want to do this in this PR.
| 11 | ||
| 17 |
There was a problem hiding this comment.
Shouldn't these versions be defined by the entries in .project-keeper.yml?
There was a problem hiding this comment.
These versions are overwritten by PK based on property java.version in the pom.xml.
...keeper/src/test/java/com/exasol/projectkeeper/validators/files/JavaVersionExtractorTest.java
Outdated
Show resolved
Hide resolved
…rs/files/JavaVersionExtractorTest.java Co-authored-by: Christoph Kuhnke <[email protected]>
|
Closes #597