Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#508: Support Maven Toolchains #509

Merged
merged 33 commits into from
Dec 19, 2023
Merged

#508: Support Maven Toolchains #509

merged 33 commits into from
Dec 19, 2023

Conversation

kaklakariada
Copy link
Collaborator

Closes #508

@kaklakariada
Update vscode config
404994f
@kaklakariada
Upgrade github actions
662c974
@kaklakariada
Increment version & upgrade dependencies
baa0cc8
@kaklakariada
Downgrade jgit because of error:
7479e42 
java.lang.NoClassDefFoundError: org/eclipse/jgit/internal/JGitText
	at org.eclipse.jgit.internal.util.ShutdownHook.cleanup(ShutdownHook.java:85)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.lang.ClassNotFoundException: org.eclipse.jgit.internal.JGitText
@kaklakariada
Fix artifact download
6fbe666
@kaklakariada
Refactor Node installation in GH action
1a42dc6
@kaklakariada
#508: Add toolchain plugin
f1291ee
@kaklakariada
Move sonar configuration from GH workflow to generated POM
d74965c
@kaklakariada
Install Java 17 in GH Action
3b7b4fc
@kaklakariada
Update GH Actions
6de3b52
@kaklakariada
Adapt vscode config to new version
45eda70
@kaklakariada
Add comments to generated GH Workflows
7028a88
@kaklakariada
Increment major version
1610e6c
@kaklakariada
Mark PK verify workflow as generated
234efd1
@kaklakariada
Enforce Java 17 using maven-enforcer-plugin
d183cf8
@kaklakariada
#508: Add requirements & design
2928f00
@kaklakariada
#508: Update developer guide
5e3949b
@kaklakariada
Fix java versions in GH workflows
fd30dd2
@kaklakariada
Add changelog entry
cdfc530
@kaklakariada
Fix java versions
c77bfa2
@kaklakariada
Fix test under windows
9939c38
@kaklakariada
Fix go caching
e8ba891
@kaklakariada
Add debug output for java_home
e7803bb
@kaklakariada
Fix integration test
798019f
@kaklakariada
Generate org.eclipse.jdt.core.prefs with correct Java version
7bbbcf8
@kaklakariada
Fix sonar analysis
6368d4d
@kaklakariada
Restore fix
e7335ab
@kaklakariada
Rename setup-java action
12a7d65
@kaklakariada
Fix running PK
020cba5
@kaklakariada
Add missing javadoc comment
0cc9ad8
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pj-spoelders
pj-spoelders approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@pj-spoelders pj-spoelders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, had a quick look. I did as good as I could since I don't have the big picture anymore with PK. Maybe KK can re-review it later but I think it looks good. Didn't see anything wrong at least. Approved.

@kaklakariada kaklakariada merged commit 9c16aec into main Dec 19, 2023
8 checks passed
@kaklakariada kaklakariada deleted the kaklakariada/issue508 branch December 19, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pj-spoelders pj-spoelders pj-spoelders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable toolchains for Maven projects
2 participants
@kaklakariada @pj-spoelders