Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#479: Removed step "Cache go-licenses" from project-keeper-verify.yml #482

Merged
merged 3 commits into from
Oct 24, 2023
Merged

#479: Removed step "Cache go-licenses" from project-keeper-verify.yml #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f1610a
#479: Remove "Cache go-licenses" step
kaklakariada Oct 23, 2023
e214bcf
Merge remote-tracking branch 'origin/main' into kaklakariada/issue479
kaklakariada Oct 24, 2023
72ea2ea
#479 Add changelog entry
kaklakariada Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion doc/changes/changes_2.9.13.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@ Code name: Remove Enforcer Plugin

This release removes plugins from the generated `dependencies.md` file that are defined by Maven itself. This avoids a dependency on the Maven version which allows using any version you want.

The release also reduces build verbosity by setting the `quiet` option of `maven-javadoc-plugin` to `true`.
The release also reduces build verbosity by setting the `quiet` option of `maven-javadoc-plugin` to `true` and removes step "Cache go-licenses" from `project-keeper-verify.yml` to fix warnings about existing files already when restoring the cache.

## Features

* #480: Removed indirect plugins from `dependencies.md` & remove enforcer plugin

## Bugfixes

* #479: Removed step "Cache go-licenses" from project-keeper-verify.yml

## Dependency Updates

### Project-Keeper Shared Model Classes
Expand Down
15 changes: 4 additions & 11 deletions ...keeper/src/main/resources/non_maven_templates/.github/workflows/project-keeper-verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ jobs:
uses: actions/setup-go@v4
with:
go-version: "1.20"
cache-dependency-path: |
go.sum
.github/workflows/project-keeper-verify.yml
.github/workflows/project-keeper.sh

$npmSetup

Expand All @@ -39,16 +43,5 @@ $npmSetup
restore-keys: |
${{ runner.os }}-pk-

- name: Cache go-licenses
uses: actions/cache@v3
with:
path: |
~/.cache/go-build
~/go/pkg/mod
key: ${{ runner.os }}-go-licenses-${{ hashFiles('.github/workflows/project-keeper-verify.yml') }}
restore-keys: |
${{ runner.os }}-go-licenses-${{ hashFiles('.github/workflows/project-keeper-verify.yml') }}
${{ runner.os }}-go-licenses-

- name: Project Keeper Verify
run: ./.github/workflows/project-keeper.sh
Loading