Skip to content

Commit

Permalink
Fix Java 21 build
Browse files Browse the repository at this point in the history
  • Loading branch information
kaklakariada committed Nov 21, 2024
1 parent 6fda61e commit ed431fe
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci-build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions .project-keeper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ version:
excludes:
# PK can't use itself as a Maven plugin
- regex: "W-PK-CORE-151: Pom file .* contains no reference to project-keeper-maven-plugin."
# Build with Java 21 fails due to missing JavaDoc comments, see https://github.com/exasol/project-keeper/issues/596
###- "E-PK-CORE-17: Missing required file: '.github/workflows/ci-build-next-java.yml'"
# No configuration necessary for aggregator POM
- "E-PK-CORE-103: Missing parent declaration in 'pom.xml'"
- "E-PK-CORE-17: Missing required file: 'pk_generated_parent.pom'"
Expand Down Expand Up @@ -135,6 +133,16 @@ build:
ls -lh coverage-aggregator/target/metrics.json
cat coverage-aggregator/target/metrics.json
# Build with Java 21 fails due to missing JavaDoc comments, see https://github.com/exasol/project-keeper/issues/596
- action: REPLACE
job: next-java-compatibility
stepId: build-next-java
content:
name: Run tests and build with Maven 21
id: build-next-java
# Only run tests as javadoc has warnings with Java 21
run: mvn --batch-mode clean test -DtrimStackTrace=false -Djava.version=21

# [itest->dsn~customize-build-process.dependency-check~0]
- name: "dependencies_check.yml"
stepCustomizations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ jobs:
java-version: $nextJavaVersion
cache: "maven"
- name: Run tests and build with Maven $nextJavaVersion
id: build-next-java
run: mvn --batch-mode clean package -DtrimStackTrace=false -Djava.version=$nextJavaVersion

build:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ jobs:
java-version: $nextJavaVersion
cache: "maven"
- name: Run tests and build with Maven $nextJavaVersion
id: build-next-java
run: mvn --batch-mode clean package -DtrimStackTrace=false -Djava.version=$nextJavaVersion

build:
Expand Down

0 comments on commit ed431fe

Please sign in to comment.