Downgrade maven-source-plugin

exasol · May 8, 2024 · c0fda46 · c0fda46
1 parent b0954a2
commit c0fda46
Show file tree

Hide file tree

Showing 8 changed files with 29 additions and 16 deletions.
diff --git a/dependencies.md b/dependencies.md
diff --git a/doc/changes/changes_4.3.1.md b/doc/changes/changes_4.3.1.md
@@ -23,7 +23,6 @@ This release fixes vulnerability CVE-2024-31573 in `org.xmlunit:xmlunit-core:jar
 * Updated `com.exasol:error-code-crawler-maven-plugin:2.0.2` to `2.0.3`
 * Updated `org.apache.maven.plugins:maven-deploy-plugin:3.1.1` to `3.1.2`
 * Updated `org.apache.maven.plugins:maven-gpg-plugin:3.2.2` to `3.2.4`
-* Updated `org.apache.maven.plugins:maven-source-plugin:3.2.1` to `3.3.1`
 * Updated `org.apache.maven.plugins:maven-toolchains-plugin:3.1.0` to `3.2.0`
 
 ### Project Keeper Core
@@ -48,7 +47,6 @@ This release fixes vulnerability CVE-2024-31573 in `org.xmlunit:xmlunit-core:jar
 * Updated `org.apache.maven.plugins:maven-deploy-plugin:3.1.1` to `3.1.2`
 * Updated `org.apache.maven.plugins:maven-gpg-plugin:3.2.2` to `3.2.4`
 * Updated `org.apache.maven.plugins:maven-jar-plugin:3.3.0` to `3.4.1`
-* Updated `org.apache.maven.plugins:maven-source-plugin:3.2.1` to `3.3.1`
 * Updated `org.apache.maven.plugins:maven-toolchains-plugin:3.1.0` to `3.2.0`
 
 ### Project Keeper Command Line Interface
@@ -67,7 +65,6 @@ This release fixes vulnerability CVE-2024-31573 in `org.xmlunit:xmlunit-core:jar
 * Updated `org.apache.maven.plugins:maven-deploy-plugin:3.1.1` to `3.1.2`
 * Updated `org.apache.maven.plugins:maven-gpg-plugin:3.2.2` to `3.2.4`
 * Updated `org.apache.maven.plugins:maven-jar-plugin:3.3.0` to `3.4.1`
-* Updated `org.apache.maven.plugins:maven-source-plugin:3.2.1` to `3.3.1`
 * Updated `org.apache.maven.plugins:maven-toolchains-plugin:3.1.0` to `3.2.0`
 
 ### Project Keeper Maven Plugin
@@ -86,7 +83,6 @@ This release fixes vulnerability CVE-2024-31573 in `org.xmlunit:xmlunit-core:jar
 * Updated `com.exasol:error-code-crawler-maven-plugin:2.0.2` to `2.0.3`
 * Updated `org.apache.maven.plugins:maven-deploy-plugin:3.1.1` to `3.1.2`
 * Updated `org.apache.maven.plugins:maven-gpg-plugin:3.2.2` to `3.2.4`
-* Updated `org.apache.maven.plugins:maven-source-plugin:3.2.1` to `3.3.1`
 * Updated `org.apache.maven.plugins:maven-toolchains-plugin:3.1.0` to `3.2.0`
 
 ### Project Keeper Java Project Crawler
@@ -105,7 +101,6 @@ This release fixes vulnerability CVE-2024-31573 in `org.xmlunit:xmlunit-core:jar
 * Updated `com.exasol:error-code-crawler-maven-plugin:2.0.2` to `2.0.3`
 * Updated `org.apache.maven.plugins:maven-deploy-plugin:3.1.1` to `3.1.2`
 * Updated `org.apache.maven.plugins:maven-gpg-plugin:3.2.2` to `3.2.4`
-* Updated `org.apache.maven.plugins:maven-source-plugin:3.2.1` to `3.3.1`
 * Updated `org.apache.maven.plugins:maven-toolchains-plugin:3.1.0` to `3.2.0`
 
 ### Project Keeper Shared Test Setup

diff --git a/maven-project-crawler/pk_generated_parent.pom b/maven-project-crawler/pk_generated_parent.pom
diff --git a/project-keeper-cli/pk_generated_parent.pom b/project-keeper-cli/pk_generated_parent.pom
diff --git a/project-keeper-maven-plugin/pk_generated_parent.pom b/project-keeper-maven-plugin/pk_generated_parent.pom
diff --git a/project-keeper/pk_generated_parent.pom b/project-keeper/pk_generated_parent.pom
diff --git a/project-keeper/src/main/resources/maven_templates/maven-source-plugin.xml b/project-keeper/src/main/resources/maven_templates/maven-source-plugin.xml
@@ -1,7 +1,10 @@
 <plugin>
     <groupId>org.apache.maven.plugins</groupId>
     <artifactId>maven-source-plugin</artifactId>
-    <version>3.3.1</version>
+    <!-- Upgrading to 3.3.0 causes the following error:
+         Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork (attach-sources) on project project-keeper-shared-model-classes: Presumably you have configured maven-source-plugn to execute twice times in your build. You have to configure a classifier for at least on of them.
+         Using goal "jar-no-fork" didn't help. See https://stackoverflow.com/questions/76305897/maven-build-fails-after-upgrading-to-maven-source-plugin-from-3-2-1-to-3-3-0 -->
+    <version>3.2.1</version>
     <executions>
         <execution>
             <id>attach-sources</id>

diff --git a/shared-model-classes/pk_generated_parent.pom b/shared-model-classes/pk_generated_parent.pom