Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit #2

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Initial commit #2

merged 8 commits into from
Oct 11, 2023

Conversation

ckunki
Copy link
Collaborator

@ckunki ckunki commented Oct 10, 2023 •
edited
Loading

closes #1

kaklakariada
kaklakariada requested changes Oct 10, 2023
View reviewed changes
.github/actions/prepare_poetry_env/action.yml Show resolved Hide resolved
.github/actions/prepare_poetry_env/action.yml Show resolved Hide resolved
.github/actions/prepare_poetry_env/action.yml Show resolved Hide resolved
.github/workflows/ci_build.yaml Show resolved Hide resolved
.github/workflows/ci_build.yaml Outdated Show resolved Hide resolved
notebook_connector/secret_store.py Show resolved Hide resolved
notebook_connector/poetry.lock Outdated Show resolved Hide resolved
tkilias
tkilias reviewed Oct 11, 2023
View reviewed changes
notebook_connector/secret_store.py Show resolved Hide resolved
notebook_connector/secret_store.py Outdated Show resolved Hide resolved
notebook_connector/secret_store.py Outdated Show resolved Hide resolved
test/test_secret_store.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@ckunki ckunki merged commit bd456b8 into main Oct 11, 2023
1 check passed
@ckunki ckunki deleted the 1-add-secret-store branch October 11, 2023 08:27
ckunki added a commit that referenced this pull request Oct 13, 2023
@ckunki
fix #2
feca8bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkilias tkilias tkilias left review comments

@kaklakariada kaklakariada kaklakariada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add secret store
3 participants
@ckunki @kaklakariada @tkilias