Implemented ticket #329 and fixed authorized_keys #339

ckunki · 2023-06-06T11:55:36Z

fixes #329

All Submissions:

Is the title of the Pull Request correct?
Is the title of the corresponding issue correct?
Have you updated the changelog?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Yes there are other pull requests
Are you mentioning the issue which this PullRequest fixes ("Fixes...")
Before you merge don't forget to run all tests for all Exasol version, by adding [run all tests] to the commit message
Are the CLI usage examples up to date?

exasol_integration_test_docker_environment/cli/commands/spawn_test_environment.py

exasol_integration_test_docker_environment/cli/options/test_environment_options.py

exasol_integration_test_docker_environment/lib/api/spawn_test_environment.py

...ol_integration_test_docker_environment/lib/api/spawn_test_environment_with_test_container.py

exasol_integration_test_docker_environment/lib/test_environment/spawn_test_database.py

exasol_integration_test_docker_environment/lib/test_environment/spawn_test_environment.py

...est_docker_environment/lib/test_environment/parameter/external_test_environment_parameter.py

pytest_itde/__init__.py

…mentation and unit test

Increased next planned version to 2.0.0 to indicate breaking changes in class DatabaseInfo.

see https://stackoverflow.com/questions/128573/using-property-on-classmethods

doc/developer_guide/developer_guide.rst

exasol_integration_test_docker_environment/lib/test_environment/ports.py

test/unit/test_abstract_spawn_test_environment.py

doc/changes/changes_2.0.0.md

..._integration_test_docker_environment/lib/test_environment/abstract_spawn_test_environment.py

exasol_integration_test_docker_environment/lib/test_environment/ports.py

exasol_integration_test_docker_environment/lib/test_environment/spawn_test_database.py

exasol_integration_test_docker_environment/test/test_cli_test_environment.py

test/unit/test_abstract_spawn_test_environment.py

…ment_info

pytest_itde/__init__.py

# Conflicts: # test/integration/test_ssh_access.py

test/integration/conftest.py

to avoid need to import conftest.py

# Conflicts: # doc/changes/changelog.md # pyproject.toml

test/integration/test_ssh_access.py

ckunki added 3 commits June 6, 2023 13:41

Implemented ticket #329 and fixed authorized_keys

92d6a29

Updated changelog

34417ee

removed stray parenthesis in test_cli_test_environment.py

a2eb031

tkilias requested changes Jun 6, 2023

View reviewed changes

ckunki added 9 commits June 6, 2023 17:50

Fixed some review findings

e475c9e

Added generation of environment variable DATABASE_SSH_PORT incl. docu…

29e0617

…mentation and unit test

Fixed review findings

bfd28b3

Increased next planned version to 2.0.0 to indicate breaking changes in class DatabaseInfo.

fixed syntax error

d21dae5

fixed changelog

af17e7a

updated version number in file pyproject.toml

798da92

fixed test

3f0c3b8

Added mandatory parameters to test case

2adeb4e

changed class level property to method

28c18dd

see https://stackoverflow.com/questions/128573/using-property-on-classmethods

This was referenced Jun 9, 2023

ITDE: Unify ports for database, BucketFS, and SSH #308

Closed

Add port, keys, user to DatabaseInfo with parent field ssh_info #343

Closed

Enable to specify individual SSH key in api, cli, and pytest_itde #345

Open

ckunki added 8 commits June 9, 2023 12:16

changed default fort for SSH port forwarding to 20002

bd1894f

fixed test

a1ae38a

Fixed test

0faf96b

Fixed test

c323f28

refactored class PortForwarding

7e0fe22

updated files in eitde/docker_db_config/

fdecff0

Renamed class PortForwarding to Ports

9272968

Updated user guide and fixes test

403cb52

ckunki mentioned this pull request Jun 12, 2023

Forward SSH port #329

Closed

tkilias reviewed Jun 12, 2023

View reviewed changes

doc/developer_guide/developer_guide.rst Outdated Show resolved Hide resolved

exasol_integration_test_docker_environment/lib/test_environment/ports.py Outdated Show resolved Hide resolved

tkilias requested changes Jun 12, 2023

View reviewed changes

test/unit/test_abstract_spawn_test_environment.py Outdated Show resolved Hide resolved

tkilias requested changes Jun 12, 2023

View reviewed changes

ckunki added 2 commits June 12, 2023 16:40

Fixed review findings

e5c45b0

Updated changes file

b25078e

ckunki added 2 commits June 14, 2023 08:30

changed ShellVariables to infer test_container_name from test_environ…

5494032

…ment_info

removed commented out import

b03aea7

tkilias requested changes Jun 14, 2023

View reviewed changes

pytest_itde/__init__.py Show resolved Hide resolved

fixed review findings.

d5bbe2f

ckunki requested a review from tkilias June 14, 2023 16:07

Merge branch 'main' into feature/329_forward_ssh_port

70a54cc

# Conflicts: # test/integration/test_ssh_access.py

tkilias previously approved these changes Jun 15, 2023

View reviewed changes

ckunki dismissed tkilias’s stale review via a824b17 June 15, 2023 14:33

ckunki added 2 commits June 15, 2023 16:33

fixed merge error

a824b17

[run all tests]

6195a02

tkilias requested changes Jun 15, 2023

View reviewed changes

test/integration/conftest.py Outdated Show resolved Hide resolved

ckunki added 11 commits June 15, 2023 17:23

Moved container_named to test_ssh_access.py

a12d5eb

to avoid need to import conftest.py

[run all tests]

8dda8c6

test with empty commit

8f7fd86

x

d5b36c2

x

61e1e7b

x2

83d5a13

x3

aecbe22

Merge branch 'main' into feature/329_forward_ssh_port

b2f2d17

# Conflicts: # doc/changes/changelog.md # pyproject.toml

[run all tests]

0a6e0f1

fixed test_udf_execution.py

caab992

[run all tests]

1647981

tkilias requested changes Jun 20, 2023

View reviewed changes

test/integration/test_ssh_access.py Outdated Show resolved Hide resolved

fixed review finding

9de3bea

ckunki requested a review from tkilias June 20, 2023 07:27

changed import

094f13d

tkilias approved these changes Jun 20, 2023

View reviewed changes

[run all tests]

307ec1f

ckunki merged commit 91e9b25 into main Jun 20, 2023

ckunki deleted the feature/329_forward_ssh_port branch June 20, 2023 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented ticket #329 and fixed authorized_keys #339

Implemented ticket #329 and fixed authorized_keys #339

ckunki commented Jun 6, 2023 •

edited

Loading

Implemented ticket #329 and fixed authorized_keys #339

Implemented ticket #329 and fixed authorized_keys #339

Conversation

ckunki commented Jun 6, 2023 • edited Loading

All Submissions:

ckunki commented Jun 6, 2023 •

edited

Loading