Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#240 Remove method ExasolContainer.withClusterLogsPath() #241

Merged
merged 6 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
dependencies.md linguist-generated=true
doc/changes/changelog.md linguist-generated=true
pk_generated_parent.pom linguist-generated=true
.github/workflows/ci-build.yml linguist-generated=true
.github/workflows/broken_links_checker.yml linguist-generated=true
.github/workflows/ci-build-next-java.yml linguist-generated=true
.github/workflows/dependencies_check.yml linguist-generated=true
Expand Down
47 changes: 16 additions & 31 deletions .github/workflows/ci-build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions .project-keeper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,9 @@ sources:
modules:
- maven_central
- integration_tests
excludes:
- "E-PK-CORE-18: Outdated content: '.github/workflows/ci-build.yml'"
build:
runnerOs: ubuntu-latest
freeDiskSpace: true
exasolDbVersions:
- "8.23.1"
- "7.1.24"
176 changes: 87 additions & 89 deletions dependencies.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions doc/changes/changelog.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 34 additions & 0 deletions doc/changes/changes_7.0.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# Test Containers for Exasol on Docker 7.0.0, released 2023-11-22

Code name: Removed `withClusterLogsPath()`

## Summary

This release removes method `ExasolContainer.withClusterLogsPath()` because the underlying method `addFileSystemBind()` is broken. We decided to remove the method because it is not widely used.

## Breaking Change

* #240: Removed `ExasolContainer.withClusterLogsPath()`

## Dependency Updates

### Compile Dependency Updates

* Updated `com.exasol:database-cleaner:1.1.1` to `1.1.2`
* Removed `org.apache.commons:commons-compress:1.24.0`
* Removed `org.apache.derby:derbyclient:10.14.2.0`
* Updated `org.testcontainers:jdbc:1.19.1` to `1.19.2`
* Updated `org.testcontainers:testcontainers:1.19.1` to `1.19.2`

### Test Dependency Updates

* Updated `com.exasol:udf-api-java:1.0.3` to `1.0.4`
* Added `org.apache.derby:derbyclient:10.14.2.0`
* Updated `org.junit-pioneer:junit-pioneer:2.1.0` to `2.2.0`
* Updated `org.testcontainers:junit-jupiter:1.19.1` to `1.19.2`

### Plugin Dependency Updates

* Updated `com.exasol:project-keeper-maven-plugin:2.9.15` to `2.9.16`
* Updated `org.apache.maven.plugins:maven-javadoc-plugin:3.6.0` to `3.6.2`
* Updated `org.apache.maven.plugins:maven-surefire-plugin:3.1.2` to `3.2.2`
7 changes: 2 additions & 5 deletions doc/design.md
Original file line number Diff line number Diff line change
Expand Up @@ -416,14 +416,11 @@ Needs: impl, utest, itest

### Mapping the Cluster Log Directory to the Host

`dsn~mapping-the-log-directory-to-the-host~1`
`dsn~mapping-the-log-directory-to-the-host~2`

The `ExasolContainer` lets integrators map the cluster log directory to a configurable directory on the host.

Covers:
* [`req~reading-log-files~1`](system_requirements.md#reading-log-files)

Needs: impl, itest
This feature was removed because mapping the log directory with `addFileSystemBind()` is broken and does not work any more, see [#240](https://github.com/exasol/exasol-testcontainers/issues/240).

### Clock Synchronization for Log Timestamp Correlation
`dsn~clock-synchronization~1`
Expand Down
Loading
Loading