#114 Added path builder function #115
Conversation
| @@ -119,6 +128,7 @@ def __init__( | |||
| username: str, | |||
| password: str, | |||
| verify: bool | str = True, | |||
| service_name: Optional[str] = None | |||
There was a problem hiding this comment.
why add the service name this breaks separation of the layers?
(Lower layers should not now know the upper layers)
There was a problem hiding this comment.
I apologize for bringing this up late, but it seems I have missed the presence of service_name in Bucketlike. I assume that there were reasons for its implementation, but I would like to discuss this further as it may be problematic and could potentially break the abstraction of the layers.
|
We need to be able to implement the |
| @@ -272,6 +287,9 @@ def parent(self) -> str: | |||
| def as_uri(self) -> str: | |||
| return self._path.as_uri() | |||
There was a problem hiding this comment.
@Nicoretti @ahsimb This will be a file uri of the form file:///path/to/somewhere is this the intention
There was a problem hiding this comment.
Yes, it will return 'file:///...'. Whether we need it or not, I don't know.
| def __init__(self, url: str, account_id: str, database_id: str, pat: str) -> None: | ||
| self._url = url | ||
| self._account_id = account_id | ||
| self.database_id = database_id |
There was a problem hiding this comment.
| self.database_id = database_id | |
| self._database_id = database_id |
There was a problem hiding this comment.
Will fix when I provide an implementation for this class.
| raise NotImplementedError() | ||
|
|
||
| def __str__(self): | ||
| return f"SaaSBucket<{self.name} | on: {self._url}>" |
There was a problem hiding this comment.
maybe we should include the account_id and database_id, they are necessary to identify the bucket
closes #114