Skip to content

Commit

Permalink
#326 Fixed few deficiencies (#327)
Browse files Browse the repository at this point in the history
* #326 Fixed few deficiencies

* [CodeBuild]
  • Loading branch information
ahsimb authored Sep 6, 2024
1 parent 37fc7e2 commit c25dcc2
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 7 deletions.
7 changes: 7 additions & 0 deletions doc/changes/changes_3.1.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,10 @@

* #324 Used pytest-plugins in notebook tests.

## Bug Fixes

* #326
- Scikit-learn notebook: call model's fit and predict with numpy arrays;
- Ibis notebook: added a link to this notebook on the front page;
- Configuration: added internal bucket-fs host name and port;
- Upgraded jupyterlab to 4.2.5.
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
jupyterlab==4.1.1
jupyterlab==4.2.5
pexpect==4.8.0
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
" # Call the model to get the predictions. Omit the first column in the input\n",
" # which holds the sample IDs.\n",
" df_features = X_pred.drop(X_pred.columns[0], axis=1)\n",
" y_pred = model.predict(df_features)\n",
" y_pred = model.predict(df_features.values)\n",
"\n",
" # Combine predictions with the sample IDs.\n",
" df_rowid = X_pred[X_pred.columns[0]].reset_index(drop=True)\n",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"\n",
"# Create and train the model.\n",
"model = tree.DecisionTreeClassifier()\n",
"model.fit(X_train.values, y_train)\n",
"model.fit(X_train.values, y_train.values)\n",
"\n",
"print(f\"Training took: {stopwatch}\")"
]
Expand All @@ -118,7 +118,7 @@
"import matplotlib.pyplot as plt\n",
"\n",
"# Make the predictions on the validation set.\n",
"y_pred = model.predict(X_valid)\n",
"y_pred = model.predict(X_valid.values)\n",
"\n",
"# Build and display the confusion matrix.\n",
"cm = confusion_matrix(y_valid, y_pred, labels=model.classes_)\n",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"1. [Transformers extension](transformers/te_introduction.ipynb)\n",
"1. [Cloud store](cloud/01_import_data.ipynb)\n",
"1. [Script Languages Container](script_languages_container/using_the_script_languages_container_tool.ipynb)\n",
"1. [Using IBIS dataframe library](ibis/quickstart.ipynb)\n",
"\n"
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
"\n",
" inputs = [\n",
" [\n",
" ('Host Name', widgets.Text(value=conf.get(CKey.db_host_name, '127.0.0.1')), CKey.db_host_name),\n",
" ('Host Name', widgets.Text(value=conf.get(CKey.db_host_name, 'localhost')), CKey.db_host_name),\n",
" ('Port', widgets.IntText(value=int(conf.get(CKey.db_port, '8563'))), CKey.db_port),\n",
" ('User Name', widgets.Text(value=conf.get(CKey.db_user)), CKey.db_user),\n",
" ('Password', widgets.Password(value=conf.get(CKey.db_password)), CKey.db_password),\n",
Expand All @@ -113,8 +113,10 @@
" CKey.db_encryption)\n",
" ],\n",
" [\n",
" ('Host Name', widgets.Text(value=conf.get(CKey.bfs_host_name, '127.0.0.1')), CKey.bfs_host_name),\n",
" ('Port', widgets.IntText(value=int(conf.get(CKey.bfs_port, '2580'))), CKey.bfs_port),\n",
" ('External Host Name', widgets.Text(value=conf.get(CKey.bfs_host_name, 'localhost')), CKey.bfs_host_name),\n",
" ('Internal Host Name', widgets.Text(value=conf.get(CKey.bfs_host_name, 'localhost')), CKey.bfs_internal_host_name),\n",
" ('External Port', widgets.IntText(value=int(conf.get(CKey.bfs_port, '2580'))), CKey.bfs_port),\n",
" ('Internal Port', widgets.IntText(value=int(conf.get(CKey.bfs_port, '2580'))), CKey.bfs_internal_port),\n",
" ('User Name', widgets.Text(value=conf.get(CKey.bfs_user)), CKey.bfs_user),\n",
" ('Password', widgets.Password(value=conf.get(CKey.bfs_password)), CKey.bfs_password),\n",
" ('Service Name', widgets.Text(value=conf.get(CKey.bfs_service, 'bfsdefault')), CKey.bfs_service),\n",
Expand Down

0 comments on commit c25dcc2

Please sign in to comment.