#17: Added vagrant setup #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The setup itself doesn't need to be reviewed, it is a copy from other repos, and we plan to unify them, anyway. |
morazow
suggested changes
Jun 6, 2023
|
|
||
| set -euo pipefail | ||
|
|
||
| echo ", +" | sudo sfdisk --force -N 3 /dev/vda |
There was a problem hiding this comment.
Maybe also add short comment what this step does?
There was a problem hiding this comment.
as, I commented, we will unify, this anyway, it doesn't help to modify each single copy of it. I will add a comment to the ticket for the unification.
There was a problem hiding this comment.
Here is the unification ticket exasol/python-toolbox#69
Co-authored-by: Muhammet Orazov <[email protected]>
morazow
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17