🚑 Improve initial state in useAsyncState and remove additional effe…

…ct in `useRUD`
exah · Mar 16, 2020 · 5509bd8 · 5509bd8
1 parent 5edfc3f
commit 5509bd8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/src/types.ts b/src/types.ts
@@ -15,7 +15,7 @@ export type Store<D extends Data = Data> = {
 
 export type AsyncState<T> =
   // initial
-  | { isReady: null; isLoading: false; error: null; result: null }
+  | { isReady: false; isLoading: false; error: null; result: null }
   // ready
   | { isReady: true; isLoading: false; error: null; result: T }
   // loading

diff --git a/src/use-async-state.ts b/src/use-async-state.ts
@@ -2,7 +2,7 @@ import { useReducer, useMemo } from 'react'
 import { AsyncState } from './types'
 
 export const INITIAL_STATE: AsyncState<null> = {
-  isReady: null,
+  isReady: false,
   isLoading: false,
   error: null,
   result: null,

diff --git a/src/use-rud.ts b/src/use-rud.ts
@@ -36,11 +36,6 @@ function useClientData<T>(fetcher: Fetcher<T>, key: Key): AsyncState<T> {
   useLayoutEffect(() => {
     if (store.exists(key)) {
       store.remove(key)
-    }
-  }, [store, key])
-
-  useLayoutEffect(() => {
-    if (store.exists(key)) {
       return
     }