fix: avoid skipping pre commit when deleted files staged #925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #919
🔧 Summary
For
pre-commit
we usegit diff --diff-filter=ACMR
and this avoids checking for deleted files. But sometimes user wants a pre-commit hook to run on any change to the files (even when deleting files). For that cases (when{staged_files}
template is not used) we should not force skipping the command/job.