fix: add general action for building both commands and do actions

internal/config/command.go

@@ -10,7 +10,7 @@ import (
 	"github.com/evilmartians/lefthook/internal/system"
 )
 
-var errFilesIncompatible = errors.New("One of your runners contains incompatible file types")
+var ErrFilesIncompatible = errors.New("One of your runners contains incompatible file types")
 
 type Command struct {
 	Run   string `json:"run"             mapstructure:"run"   toml:"run"             yaml:"run"`
@@ -39,16 +39,16 @@ type commandRunReplace struct {
 }
 
 func (c Command) Validate() error {
-	if !isRunnerFilesCompatible(c.Run) {
-		return errFilesIncompatible
+	if !IsRunnerFilesCompatible(c.Run) {
+		return ErrFilesIncompatible
 	}
 
 	return nil
 }
 
 func (c Command) DoSkip(state func() git.State) bool {
 	skipChecker := NewSkipChecker(system.Cmd)
-	return skipChecker.check(state, c.Skip, c.Only)
+	return skipChecker.Check(state, c.Skip, c.Only)
 }
 
 func (c Command) ExecutionPriority() int {

internal/config/do.go

@@ -43,6 +43,20 @@ type Group struct {
 	Do       []*Do  `json:"do,omitempty"       mapstructure:"do"       toml:"do,omitempty"       yaml:",omitempty"`
 }
 
+func (do *Do) PrintableName(id string) string {
+	if len(do.Name) != 0 {
+		return do.Name
+	}
+	if len(do.Run) != 0 {
+		return do.Run
+	}
+	if len(do.Script) != 0 {
+		return do.Script
+	}
+
+	return "(" + id + ")"
+}
+
 func (do *Do) Validate() error {
 	if len(do.Run) > 0 && len(do.Script) > 0 {
 		return errAmbiguousDo

internal/config/files.go

@@ -9,7 +9,7 @@ const (
 	SubPushFiles   string = "{push_files}"
 )
 
-func isRunnerFilesCompatible(runner string) bool {
+func IsRunnerFilesCompatible(runner string) bool {
 	if strings.Contains(runner, SubStagedFiles) && strings.Contains(runner, SubPushFiles) {
 		return false
 	}

internal/config/hook.go

@@ -47,7 +47,7 @@ func (h *Hook) Validate() error {
 
 func (h *Hook) DoSkip(state func() git.State) bool {
 	skipChecker := NewSkipChecker(system.Cmd)
-	return skipChecker.check(state, h.Skip, h.Only)
+	return skipChecker.Check(state, h.Skip, h.Only)
 }
 
 func unmarshalHooks(base, extra *viper.Viper) (*Hook, error) {

internal/config/script.go

@@ -31,7 +31,7 @@ type scriptRunnerReplace struct {
 
 func (s Script) DoSkip(state func() git.State) bool {
 	skipChecker := NewSkipChecker(system.Cmd)
-	return skipChecker.check(state, s.Skip, s.Only)
+	return skipChecker.Check(state, s.Skip, s.Only)
 }
 
 func (s Script) ExecutionPriority() int {

internal/config/skip_checker.go

@@ -17,7 +17,7 @@ func NewSkipChecker(cmd system.Command) *skipChecker {
 }
 
 // check returns the result of applying a skip/only setting which can be a branch, git state, shell command, etc.
-func (sc *skipChecker) check(state func() git.State, skip interface{}, only interface{}) bool {
+func (sc *skipChecker) Check(state func() git.State, skip interface{}, only interface{}) bool {
 	if skip == nil && only == nil {
 		return false
 	}

internal/config/skip_checker_test.go

@@ -151,7 +151,7 @@ func TestDoSkip(t *testing.T) {
 		},
 	} {
 		t.Run(tt.name, func(t *testing.T) {
-			if skipChecker.check(tt.state, tt.skip, tt.only) != tt.skipped {
+			if skipChecker.Check(tt.state, tt.skip, tt.only) != tt.skipped {
 				t.Errorf("Expected: %v, Was %v", tt.skipped, !tt.skipped)
 			}
 		})

internal/lefthook/runner/action/action.go

@@ -0,0 +1,85 @@
+package action
+
+import (
+	"github.com/evilmartians/lefthook/internal/config"
+	"github.com/evilmartians/lefthook/internal/git"
+	"github.com/evilmartians/lefthook/internal/system"
+)
+
+type Params struct {
+	Repo       *git.Repository
+	Hook       *config.Hook
+	HookName   string
+	GitArgs    []string
+	Force      bool
+	ForceFiles []string
+
+	Run       string
+	Root      string
+	Glob      string
+	Files     string
+	FileTypes []string
+	Tags      []string
+	Exclude   interface{}
+	Only      interface{}
+	Skip      interface{}
+}
+
+type Action struct {
+	Execs []string
+	Files []string
+}
+
+func New(name string, params *Params) (*Action, error) {
+	if params.skip() {
+		return nil, SkipError{"settings"}
+	}
+
+	if intersect(params.Hook.ExcludeTags, params.Tags) {
+		return nil, SkipError{"tags"}
+	}
+
+	if intersect(params.Hook.ExcludeTags, []string{name}) {
+		return nil, SkipError{"name"}
+	}
+
+	if err := params.validate(); err != nil {
+		return nil, err
+	}
+
+	action, err := build(params)
+	if err != nil {
+		return nil, err
+	}
+
+	return action, nil
+}
+
+func (p *Params) skip() bool {
+	skipChecker := config.NewSkipChecker(system.Cmd)
+	return skipChecker.Check(p.Repo.State, p.Skip, p.Only)
+}
+
+func (p *Params) validate() error {
+	if !config.IsRunnerFilesCompatible(p.Run) {
+		return config.ErrFilesIncompatible
+	}
+
+	return nil
+}
+
+func intersect(a, b []string) bool {
+	intersections := make(map[string]struct{}, len(a))
+
+	for _, v := range a {
+		intersections[v] = struct{}{}
+	}
+
+	for _, v := range b {
+		if _, ok := intersections[v]; ok {
+			return true
+		}
+	}
+
+	return false
+}