Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreZoom option to maps #3022

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Add ignoreZoom option to maps #3022

merged 9 commits into from
Jan 24, 2025

Conversation

hughess
Copy link
Member

@hughess hughess commented Jan 17, 2025

Description

Adds an ignoreZoom prop to the following map components to allow control over map layers auto-adjusting zoom and panning:

  • AreaMap
  • PointMap
  • BubbleMap
  • Areas
  • Points
  • Bubbles

Before - zoom includes all layers

CleanShot 2025-01-22 at 12 37 56@2x

After - ignoreZoom=true on Areas layer

CleanShot 2025-01-22 at 12 38 17@2x

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable

Copy link
Member

@zachstence zachstence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs ignoreZoom prop handling added to BubbleMap and Bubbles.

Needs docs additions for AreaMap, PointMap, and BubbleMap.

Needs stories (maybe with a play function?) to illustrate what ignoreZoom does and test it with Chromatic snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants