Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC full screen charts #3007

Merged
merged 1 commit into from
Jan 17, 2025
Merged

POC full screen charts #3007

merged 1 commit into from
Jan 17, 2025

Conversation

archiewood
Copy link
Member

@archiewood archiewood commented Jan 14, 2025 •
edited
Loading

Description

CleanShot.2025-01-14.at.10.26.09.mp4

To Do

  • Move EnterFullScreen component to more sane location
  • Calculate height more carefully
  • Test edge cases
    • title
    • title and subtitle
    • user has custom height for chart
    • graph is in grid

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

@archiewood archiewood changed the title poc full screen charts POC full screen charts Jan 14, 2025
@archiewood archiewood requested a review from kwongz January 14, 2025 15:44
@archiewood
Copy link
Member Author

archiewood commented Jan 14, 2025 •
edited
Loading

@kwongz you did some of this work i think? Can you throw a few rocks at this

Also, given your experience with the datatable, how should I think about height?

@archiewood archiewood merged commit 49f76f0 into next Jan 17, 2025
51 of 62 checks passed
@archiewood archiewood deleted the full-screen-charts branch January 17, 2025 22:55
This was referenced Jan 23, 2025
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwongz kwongz Awaiting requested review from kwongz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@archiewood