Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate social images #2985

Merged
merged 13 commits into from
Jan 9, 2025
Merged

Generate social images #2985

merged 13 commits into from
Jan 9, 2025

Conversation

archiewood
Copy link
Member

@archiewood archiewood commented Jan 8, 2025 •
edited
Loading

Description

Generate unique social cards for every route in the docs site

Outstanding

  • Override with manually specified og image if it exists
  • Make twitter compliant
  • Lack of ability to set sidebar name and title of page is annoying
  • Actually write descriptions for every page -> Another PR

To Review

Paste the vercel links into a preview tool. Or paste directly into a platform. (Note that Twitter will not work until merged as it requires fully qualified URLs)

Examples

components_charts_area-chart_og
core-concepts_data-sources_og

All Images
Image 1 Image 2 Image 3 Image 4
Image 5 Image 6 Image 7 Image 8
Image 9 Image 10 Image 11 Image 12
Image 13 Image 14 Image 15 Image 16
Image 17 Image 18 Image 19 Image 20
Image 21 Image 22 Image 23 Image 24
Image 25 Image 26 Image 27 Image 28
Image 29 Image 30 Image 31 Image 32
Image 33 Image 34 Image 35 Image 36
Image 37 Image 38 Image 39 Image 40
Image 41 Image 42 Image 43 Image 44
Image 45 Image 46 Image 47 Image 48
Image 49 Image 50 Image 51 Image 52
Image 53 Image 54 Image 55 Image 56
Image 57 Image 58 Image 59 Image 60
Image 61 Image 62 Image 63 Image 64
Image 65 Image 66 Image 67 Image 68
Image 69 Image 70 Image 71 Image 72
Image 73 Image 74 Image 75 Image 76
Image 77 Image 78 Image 79 Image 80
Image 81 Image 82 Image 83 Image 84
Image 85 Image 86 Image 87 Image 88
Image 89 Image 90 Image 91 Image 92
Image 93 Image 94 Image 95 Image 96
Image 97 Image 98 Image 99

ItsMeBrianD
ItsMeBrianD approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@ItsMeBrianD ItsMeBrianD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@archiewood archiewood merged commit 3b9eaba into next Jan 9, 2025
61 checks passed
@archiewood archiewood deleted the dynamic-social-images branch January 9, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsMeBrianD ItsMeBrianD ItsMeBrianD approved these changes

@hughess hughess Awaiting requested review from hughess

@zachstence zachstence Awaiting requested review from zachstence

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archiewood @ItsMeBrianD