Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRange last day selection fix #2981

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

kwongz
Copy link
Contributor

@kwongz kwongz commented Jan 7, 2025

Description

Currently, added an extra day to max range to account for when start date and end date are on the end date range, causing the rangeCalendar to deselect the date. The extra day is disabled, to the user everything looks normal, behind the scenes we are handling what is most likely a timezone issue

Before:

Screen.Recording.2025-01-07.134437.mp4

After:

Screen.Recording.2025-01-07.134625.mp4

I attempted to test the time zones in London, SF and Toronto, the last date deselection issue persisted.

Attempted to add times to possible dates' start and end range, resulting in weird behavior. Would it best to add a new library to handle dates with times? currently, date formmater is only for dates without times.

Tried to look into changing selection dates, start selection at 00h:00m:00s and end selection 23h:59m:59s, but couldn't find a way in range calendar bits UI to handle that.

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

@kwongz kwongz changed the title Added Extra day to accomodate timezone issues DateRange last day selection fix Jan 7, 2025
@ItsMeBrianD
Copy link
Member

Need to test this with data that is hourly instead of daily to make sure we aren't overdisplaying

@kwongz
Copy link
Contributor Author

kwongz commented Jan 9, 2025

image

Currently, the Max date is Wed Jun 19 2024 20:00:00 GMT-0400 (Eastern Daylight Time), which goes into Thursday June 20th UTC time.

With the 'extraDay - date disabled' fix the daterange does not over display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants