Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up error messages #2972

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Clean up error messages #2972

wants to merge 3 commits into from
+28 −12

Conversation

hughess
Copy link
Member

@hughess hughess commented Jan 3, 2025 •
edited
Loading

Description

This is a work in progress - will continue to add error message fixes, cleanups, and removals here

Current list:

  • 404 for all-queries.json - function updated to return blank object if no queries on a page
  • Page threw a non-error - no longer logs to console (hooks.client.js + hooks.server.js)
  • DimensionGrid
    • Now uses ErrorChart rather than Alert
    • Error message added when no string columns found in query

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hughess