Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning default index page #2957

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Warning default index page #2957

merged 2 commits into from
Jan 2, 2025

Conversation

archiewood
Copy link
Member

Description

If you delete the index.md page, then you you puzzlingly get the +page.md from the example-project

This adds a warning to help users rectify this case

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

ItsMeBrianD
ItsMeBrianD approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@ItsMeBrianD ItsMeBrianD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like preventing this page from being copied at all might be a better fix, but this seems okay

@archiewood archiewood merged commit 0b441cf into next Jan 2, 2025
60 of 62 checks passed
@archiewood archiewood deleted the warning-default-index-page branch January 2, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsMeBrianD ItsMeBrianD ItsMeBrianD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archiewood @ItsMeBrianD