Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input group component #2951

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

Input group component #2951

wants to merge 1 commit into from

Conversation

hughess
Copy link
Member

@hughess hughess commented Dec 21, 2024

Description

Adds an InputGroup component - a collapsible tray for inputs.

Questions

  • Should this be a component that can be placed anywhere, or a page-level setting that has a standard implementation?
  • Currently most input components take the background of their parent container. Should the background be set as base-100 instead to match the background of the app?
  • What is the right naming of this?

CleanShot 2024-12-21 at 12 44 15

Input Background

My preference is base-100 for input backgrounds, but interested in people's take - see below examples of taking parent background vs. app background:

CleanShot 2024-12-21 at 12 49 04@2x
CleanShot 2024-12-21 at 12 46 52@2x

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant