Enable Strict Mode for Sources #2913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archiewood
reviewed
Dec 13, 2024
zachstence
reviewed
Dec 13, 2024
4 tasks
archiewood
reviewed
Jan 2, 2025
| @@ -351,10 +351,12 @@ prog | |||
| .option('--sources', 'only build queries from the specified source directories') | |||
| .option('--queries', 'only build the specified queries') | |||
| .option('--debug', 'show debug output') | |||
| .option('--strict', 'Fail when a source query fails') | |||
There was a problem hiding this comment.
Suggested change
| .option('--strict', 'Fail when a source query fails') | |
| .option('--strict', 'fail when a source query fails') |
archiewood
reviewed
Jan 2, 2025
|
|
||
| await updateManifest(evaluatedManifest, dataDirectory); | ||
| console.log(chalk.bold.green(' ✅ Done!')); | ||
| log.info(chalk.bold.green(' ✅ Done!')); |
There was a problem hiding this comment.
Suggested change
| log.info(chalk.bold.green(' ✅ Done!')); | |
| log.info(chalk.bold.green(' ✔ Sources complete!')); |
- I feel like CLI logging with emojis is off brand
- "Done" always felt unspecific
archiewood
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You can now run
evidence sources --strictto cause the process to fail when an error is encountered.Checklist
For UI or styling changes, I have added a screenshot or gif showing before & afterI have added to the VS Code extension where applicable