Added macos support #151
Open
Added macos support #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ability to set 'service' value https://developer.apple.com/documentation/security/ksecattrservice
added ability to set kSecUseDataProtectionKeychain https://developer.apple.com/documentation/security/ksecusedataprotectionkeychain
|
this is unnecessary if kSecAttrSynchronizable is used right? |
|
@aehlke absolutely, it needs for the case when you don't want use iCloud sync for macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @evgenyneu!
thank you for
keychain-swift. It saves my time!But I want to share with you some behavior for macOS.
There was a problem:
I am using keychain in my macOS app to store jwt tokens (access and refresh)(
kSecClassGenericPassword) and I have figured out that I can't manage existed data via the same app with another name. I have built two equal applications with different app names:for example App1.app and App2.app
Note: it's the same build, but with only a different - app file name.
And if I create the keychain item using the first app (App1.app) I can't remove it from the second one.
If I double click on the keychain item in Keychain Access default App I can see that there is only one app in Access Control tab (with the name App1.app).
The Solution
Finally, I have found the solution in this article: Making macOS Keychain behave as iOS keychain
And have made a pull request based on this article.