Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/api_get_university] 대학 목록 조회 API 연결 #84

Merged
merged 10 commits into from
Nov 9, 2023
Merged

[feature/api_get_university] 대학 목록 조회 API 연결 #84

merged 10 commits into from
Nov 9, 2023

Conversation

SsongSik
Copy link
Member

@SsongSik SsongSik commented Nov 6, 2023

주요 작업 내용

작업 내용 정리

  • 대학 목록 조회 API 연결

변경점

  • 대학 목록 조회 API 연결하였습니다.
  • Loading UI 추가하였습니다.
  • 에러다이얼로그 추가하였습니다.
  • BaseResponse 적용하였습니다.
  • BaseResponse를 떼어내는 확장함수를 추가하였습니다.
  • 좀 빠르게 작업하느라 부족한 부분이 많습니다..! 같이 고민해보면 좋을 것 같아요!

@SsongSik SsongSik requested a review from kez-lab November 6, 2023 13:59
@SsongSik SsongSik self-assigned this Nov 6, 2023
kez-lab
kez-lab approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@kez-lab kez-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SsongSik SsongSik merged commit 1bc3d35 into develop Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kez-lab kez-lab kez-lab approved these changes

Assignees

@SsongSik SsongSik

Labels
💻 feat ssongsik
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SsongSik @kez-lab