Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/onboarding] 온보딩 화면 구성 #65

Merged
merged 5 commits into from
Oct 14, 2023
Merged

Conversation

SsongSik
Copy link
Member

@SsongSik SsongSik commented Oct 8, 2023

주요 작업 내용

작업 내용 정리

  • 온보딩 페이지 구현
  • 뭐먹지 준비화면 이미지 추가
  • 온보딩 이미지 Pager 추가

변경점

  • 뭐먹지 준비화면 간단한 화면이라 추가하였습니다!
  • 온보딩 2번째 화면에는 로티가 들어가는 화면이나, 현재 로티가 없어서 같은 이미지로 추가해두었습니다!

Copy link
Contributor

@kez-lab kez-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 저도 내일까지 리뷰 마무리하고 새로 작업 받아서 바로 진행할게요~!!

Comment on lines 40 to 45
val onBoardingList = listOf(
Triple(R.drawable.icon_onboarding_image_bowel, 160.dp, stringResource(id = R.string.onboarding_today_what_food)),
Triple(R.drawable.icon_onboarding_image_bowel, 160.dp, "여기는 로티가 들어가요"),
Triple(R.drawable.icon_onboarding_image_school, 144.dp, stringResource(id = R.string.onboarding_school_food)),
Triple(R.drawable.icon_onboarding_image_logo, 140.dp, stringResource(id = R.string.onboarding_everymeal)),
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 Triple보다는 dataClass사용 어떠신가요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵넵!! 변경해보도록 하겠습니다!!

@SsongSik SsongSik merged commit 2c35905 into develop Oct 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants