Fix/create mention from comment missing organization

[GloireMutaliko21]

PR

• Have you followed the contributing guidelines?
• Have you explained what your changes do, and why they add value?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

---

Summary by CodeRabbit

• New Features

  • Enhanced comment creation by adding organization and tenant context
  • Improved task filtering with more flexible organization sprint handling

• Refactor

  • Restructured import statements for better code readability
  • Updated method calls to include additional contextual parameters

• Bug Fixes

  • Removed default null condition for organization sprint ID in task filtering

[coderabbitai]

Walkthrough

The pull request introduces modifications across multiple services in the core package, focusing on enhancing the context of mention publishing and task filtering. The changes primarily involve adding organizationId and tenantId parameters to mention-related methods, and adjusting the task filtering logic in the TaskService. These modifications aim to provide more precise contextual information when creating comments, publishing mentions, and filtering tasks.

Changes

File	Change Summary
packages/core/src/lib/comment/comment.service.ts	Added organizationId and tenantId to publishMention method call in create method
packages/core/src/lib/tasks/commands/handlers/task-create.handler.ts	Updated import statements and added organizationId and tenantId to publishMention and CreateSubscriptionEvent method calls
packages/core/src/lib/tasks/task.service.ts	Removed conditional check for organizationSprintId in findModuleTasks method, changing task filtering logic

Possibly related PRs

• [Fix]: Activity Log update entities include relations #8508: Similar modifications to publishMention method in OrganizationProjectModuleService
• [Feat] Task Linked Issue Activity Log #8514: Changes to TaskService involving publishMention method parameters
• [Fix] Udate Project infinite blocked request #8573: Updates to OrganizationProjectService update method

Suggested Labels

hold

Suggested Reviewers

• rahul-rocket

Poem

🐰 Hopping through code with glee,
Mentions now have context, you see!
Organizations and tenants in sight,
Filtering tasks with newfound might,
A rabbit's code dance of pure delight! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbbe7bb and 8c0a804.

📒 Files selected for processing (3)

• packages/core/src/lib/comment/comment.service.ts (1 hunks)
• packages/core/src/lib/tasks/commands/handlers/task-create.handler.ts (3 hunks)
• packages/core/src/lib/tasks/task.service.ts (0 hunks)

💤 Files with no reviewable changes (1)

• packages/core/src/lib/tasks/task.service.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: test
• GitHub Check: build

🔇 Additional comments (5)

packages/core/src/lib/comment/comment.service.ts (2)

67-69: LGTM! The organization context is now correctly passed to mentions.

The changes properly add organization context to mentions by passing both organizationId and tenantId, fixing the missing organization issue.

---

67-69: Verify that organizationId is always present.

Consider adding validation to ensure comment.organizationId exists before using it in the mention creation.

packages/core/src/lib/tasks/commands/handlers/task-create.handler.ts (3)

3-11: LGTM! Import statements are now better organized.

The imports from @gauzy/contracts are now properly grouped and organized for better readability.

---

99-101: LGTM! Mention creation now includes organization context.

The changes properly add organization context to mentions, consistent with the changes in CommentService.

---

134-145: LGTM! Subscription events now include organization context.

The CreateSubscriptionEvent now correctly includes both organizationId and tenantId for proper context.

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 8c0a804.

Command	Status	Duration	Result
nx build desktop --base-href ./	✅ Succeeded	1m 58s	View ↗
nx build desktop-api --output-path=dist/apps/de...	✅ Succeeded	30s	View ↗
nx run api:desktop-api	✅ Succeeded	1m 21s	View ↗
nx run gauzy:desktop-ui --base-href ./	✅ Succeeded	4m 8s	View ↗
nx build desktop-ui-lib --configuration=production	✅ Succeeded	32s	View ↗
nx build plugin-integration-wakatime	✅ Succeeded	<1s	View ↗
nx build desktop-lib	✅ Succeeded	<1s	View ↗
nx build desktop-window	✅ Succeeded	<1s	View ↗
Additional runs (53)	✅ Succeeded	...	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-01-17 09:39:50 UTC