feat: finish read/write for single shard #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
reviewed
Feb 12, 2024
|
|
||
| impl Iterator for Iter { | ||
| type Item = Result<DataBatch>; | ||
|
|
||
| fn next(&mut self) -> Option<Self::Item> { | ||
| todo!() | ||
| while let Some(mut top) = self.heap.pop() { | ||
| if top.source.is_valid() { |
There was a problem hiding this comment.
We can guarantee nodes in the heap are valid so we don't need this check.
| @@ -186,6 +335,8 @@ impl DataBuffer { | |||
| }) | |||
| .push_value_ref(field); | |||
| } | |||
|
|
|||
| self.ts_builder.len() >= self.freeze_threshold | |||
There was a problem hiding this comment.
Maybe we should provide a len() method and check this outside of the buffer. Then we don't need to store the threshold in the buffer.
| offset: 0, | ||
| current_data_batch: None, | ||
| }; | ||
| iter.next(); // fill data batch for comparison and merge. |
There was a problem hiding this comment.
next() returns a result. We should handle it or change the return value of next().
|
I plan to merge it first. |
evenyag
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements the iter method for
DataParts. The iterator is simply a merge reader that compares the pk from both active and frozen parts ofDataPartsand merges thoseDataBatches with same pk index.Also
freezewill be triggered on write path of the num of rows inside active data buffer exceedsfreeze_thresholdinMergeTreeConfig.Checklist
Refer to a related PR or issue link (optional)