Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matrix): use bitvec-rs instead of hand-crafted bit manipulation #596

Closed
wants to merge 1 commit into from

Conversation

samueltardieu
Copy link
Collaborator

@samueltardieu samueltardieu commented Sep 5, 2024

For performance measurements only, not to merge yet.

Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #596 will degrade performances by 45.61%

Comparing bitvec-rs (c091b8e) with main (e99545d)

Summary

❌ 1 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bitvec-rs Change
transpose_non_square 160.3 µs 294.6 µs -45.61%

@samueltardieu
Copy link
Collaborator Author

Bad performance, abandoning

@samueltardieu samueltardieu deleted the bitvec-rs branch September 5, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant