Skip to content

Commit

Permalink
Update comment on WAVE extensible format
Browse files Browse the repository at this point in the history
python/cpython#9515 only adds support for
reading WAVE_FORMAT_EXTENSIBLE, not writing.
  • Loading branch information
evenbrenden committed Apr 17, 2021
1 parent 00c23ab commit f897f85
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions lib/record.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,13 +248,8 @@ def record_to_file(
return None


# TODO: WAVE files with bit depths above 16 should have extensible
# format:
# TODO: WAVE files with bit depths > 16 should use extensible format:
# http://www-mmsp.ece.mcgill.ca/Documents/AudioFormats/WAVE/WAVE.html
#
# Need https://github.com/python/cpython/pull/9515 to do this. Having
# said that, AFAIK the metadata is unambiguous (flac will issue a
# warning) and I have yet to find a parser that has a problem with it.
def save_to_file(path, sample_width, data, sample_rate=SAMPLE_RATE):
wf = wave.open(path, 'wb')
wf.setnchannels(NUM_CHANNELS)
Expand Down

0 comments on commit f897f85

Please sign in to comment.