Prevent hang in EVEmon. #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dresdor
reviewed
Apr 21, 2018
| @@ -706,7 +706,11 @@ private string AbbreviationFormat(decimal value, float width) | |||
| int suffixIndex = 0; | |||
| float newWidth; | |||
|
|
|||
| do | |||
| if (width <= 0.0f) { | |||
There was a problem hiding this comment.
should probably normalize your indentation
|
Likely the negative is caused around line 410 in the same file, where the character name width is wider than the available screen width. You should breakpoint it, if you experience the error, and see what the values are to determine if there are any other weird issues around that. |
NevarrTivianne
pushed a commit
to NevarrTivianne/evemon
that referenced
this pull request
Apr 3, 2021
Active/alpha skill level and better alpha/omega detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVEMon hangs if it somehow gets a negative width value into this function.
How the negative got there would be the next logical question but I cannot practically replicate. :(