Fix #77 skillpoints and SP/hour being wrong by guessing account status based on skill queue #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 8, 2018 22:09
…mewhere further down, so don't use that
dresdor
reviewed
Apr 21, 2018
| var hoursToTrain = (CurrentlyTrainingSkill.EndTime - CurrentlyTrainingSkill.StartTime).TotalHours; | ||
| if (hoursToTrain > 0) | ||
| { | ||
| var spToTrain = (CurrentlyTrainingSkill.EndSP - CurrentlyTrainingSkill.StartSP); |
There was a problem hiding this comment.
These really don't need to be nested. You can rewrite this to something like:
var hoursToTrain = (CurrentlyTrainingSkill.EndTime - CurrentlyTrainingSkill.StartTime).TotalHours;
var spToTrain = (CurrentlyTrainingSkill.EndSP - CurrentlyTrainingSkill.StartSP);
var spPerHour = hoursToTrain == 0 ? 0 : spToTrain/hoursToTrain;
var rate = spPerHour == 0 ? 0 : (int)Math.Round(GetOmegaSPPerHour(CurrentlyTrainingSkill.Skill) / spPerHour, 0);
then your switch statement. You could also set the spPerHour to some ludicrous value instead of 0 to avoid the second ternary operation if you wanted to
NevarrTivianne
pushed a commit
to NevarrTivianne/evemon
that referenced
this pull request
Apr 3, 2021
… by the current character. Fixes evemondevteam#77. - Update skill queue about to end message. Fixes evemondevteam#80 - Fix text overflow on notification popup if show location is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #77 which is caused by the account status defaulting to Alpha when the AccountStatus API doesn't provide an expiry date.
The number of trained skillpoints in a partially trained skill is calculated backwards based on the endtime and current skillpoints of the skill, but due to the training time incorrectly being interpreted as alpha based, even though it's omega.
The account status is now guessed based on the currently training skill, but it means that it won't be correct for Alpha characters that aren't training a skill.