Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Commit

Permalink
Removing creator_id for bookmark folders.
Browse files Browse the repository at this point in the history
That attribute was not included in the patch
pushed to the Tranquility API servers. It is
still present for individual bookmarks, just
not for folders (unlike the demo XML data).
  • Loading branch information
ayust committed Jul 14, 2015
1 parent 536a375 commit 31585be
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
1 change: 0 additions & 1 deletion evelink/parsing/bookmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ def parse_bookmarks(api_results):
folder = {
'id': folder_id,
'name': a['folderName'], # "" = toplevel
'creator_id': int(a['creatorID']),
'bookmarks': {},
}
bookmarks = row.find('rowset')
Expand Down
3 changes: 0 additions & 3 deletions tests/parsing/test_bookmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,11 @@ def test_parse_bookmarks(self):
'z': 0.0,
},
},
'creator_id': 0,
'id': 0,
'name': '',
},
1: {
'bookmarks': {},
'creator_id': 90000001,
'id': 1,
'name': 'A lovely empty folder',
},
Expand All @@ -66,7 +64,6 @@ def test_parse_bookmarks(self):
'z': -1415023302173.46,
},
},
'creator_id': 90000001,
'id': 4,
'name': 'Random crap',
},
Expand Down
6 changes: 3 additions & 3 deletions tests/xml/char/bookmarks.xml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<result>
<rowset name="folders" key="folderID" columns="folderName,creatorID">
<row folderID="0" folderName="" creatorID="0">
<row folderID="0" folderName="">
<rowset name="bookmarks" key="bookmarkID" columns="creatorID,created,itemID,typeID,locationID,x,y,z,memo,note">
<row bookmarkID="12" creatorID="90000001" created="2015-07-08 21:34:14" itemID="60014689" typeID="57" locationID="30004971" x="0" y="0" z="0" memo="Home Station" note="Our base of residence" />
<row bookmarkID="13" creatorID="90000001" created="2015-07-08 21:35:07" itemID="40314792" typeID="8" locationID="30004971" x="0" y="0" z="0" memo="Sun" note="" />
</rowset>
</row>
<row folderID="1" folderName="A lovely empty folder" creatorID="90000001">
<row folderID="1" folderName="A lovely empty folder">
<rowset name="bookmarks" key="bookmarkID" columns="creatorID,created,itemID,typeID,locationID,x,y,z,memo,note" />
</row>
<row folderID="4" folderName="Random crap" creatorID="90000001">
<row folderID="4" folderName="Random crap">
<rowset name="bookmarks" key="bookmarkID" columns="creatorID,created,itemID,typeID,locationID,x,y,z,memo,note">
<row bookmarkID="14" creatorID="90000001" created="2015-07-08 21:36:08" itemID="0" typeID="5" locationID="30004971" x="-373405654941.733" y="42718621667.0746" z="-1415023302173.46" memo="spot in Duripant solar system" note="" />
</rowset>
Expand Down

0 comments on commit 31585be

Please sign in to comment.