Refactor user, skill and cert data into separate modules #8
Conversation
|
|
||
| if not (key_id and vcode): | ||
| if not (key_id and user_data.validate_vcode(vcode)): |
There was a problem hiding this comment.
Is there a reason why you have one validation function return a new value and call it outside the conditional, and the other validation return a truth value and call it inside the conditional? I think it'd be a bit nicer to read to call both validation functions outside the conditional.
|
I've added some comments within the code itself. |
|
Heya @fastolfe - I realized I never circled back to this. I think I might have dropped some context though - were there any pending issues we had discussed that haven't been addressed? If not, I can look into merging this. |
|
I thought I'd left it in a 'done-ish' state but I admit I lost track of it On Tue Jun 04 2013 at 2:34:10 PM, Amber Yust [email protected]
|
|
Ping! Penny for your thoughts. :) |
This is for #4. No new functionality is being added and so this should behave exactly as it does today.
Some of the changes don't really simplify main.py very much (trade one line for another), but some of the code gets re-used by other modules and I didn't really want a circular dependency on main. I also couldn't think of a good way to consistently use dicts in lieu of model instances on one side of the split versus the other. Feedback welcome.