Revert "trait Serialize uses reference to self instead of move. " #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, CI breaks because of https://github.com/edn-rs/edn-derive/blob/main/Cargo.toml#L26 |
|
Do we need to merge this @Grinkers ? |
|
It looks like I forgot to revert |
|
How bad will this be? If not reverted? |
It's not really bad, just technically a breaking change. some people will have a compiler error on upgrade and have to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #37
edn-rsis reverting this move to ref for maximum compatibility. No release needs to be made.naomijub/edn-rs#156
Reference:
naomijub/edn-rs#158