Apply PR code review suggestions

Signed-off-by: Eval EXEC <[email protected]>
eval-exec · Aug 1, 2024 · 59c2cdd · 59c2cdd
1 parent 40ea0c6
commit 59c2cdd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 186 deletions.
diff --git a/chain/src/consume_unverified.rs b/chain/src/consume_unverified.rs
@@ -68,13 +68,13 @@ impl ConsumeUnverifiedBlocks {
 
     pub(crate) fn start(mut self) {
         loop {
-            let _trace_begin_loop = minstant::Instant::now();
+            let trace_begin_loop = minstant::Instant::now();
             select! {
                 recv(self.unverified_block_rx) -> msg => match msg {
                     Ok(unverified_task) => {
                         // process this unverified block
                         if let Some(handle) = ckb_metrics::handle() {
-                            handle.ckb_chain_consume_unverified_block_waiting_block_duration.observe(_trace_begin_loop.elapsed().as_secs_f64())
+                            handle.ckb_chain_consume_unverified_block_waiting_block_duration.observe(trace_begin_loop.elapsed().as_secs_f64())
                         }
                         let _ = self.tx_pool_controller.suspend_chunk_process();
 
@@ -98,7 +98,7 @@ impl ConsumeUnverifiedBlocks {
                         let _ = self.tx_pool_controller.continue_chunk_process();
                     },
                     Err(err) => {
-                        info!("truncate_block_tx has been closed,err: {}", err);
+                        info!("truncate_block_tx has been closed, err: {}", err);
                         return;
                     },
                 },
@@ -883,8 +883,6 @@ impl ConsumeUnverifiedBlockProcessor {
 
         self.shared.store_snapshot(Arc::clone(&new_snapshot));
 
-        // NOTE: Dont update tx-pool when truncate
-
         Ok(())
     }
 }

diff --git a/devtools/block_sync/draw_sync_chart.py b/devtools/block_sync/draw_sync_chart.py
diff --git a/sync/src/types/mod.rs b/sync/src/types/mod.rs
@@ -1322,7 +1322,6 @@ pub struct SyncState {
     pending_get_block_proposals: DashMap<packed::ProposalShortId, HashSet<PeerIndex>>,
     pending_get_headers: RwLock<LruCache<(PeerIndex, Byte32), Instant>>,
     pending_compact_blocks: Mutex<PendingCompactBlockMap>,
-    // orphan_block_pool: OrphanBlockPool,
 
     /* In-flight items for which we request to peers, but not got the responses yet */
     inflight_proposals: DashMap<packed::ProposalShortId, BlockNumber>,