Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback errors in retryWithDelay and retry #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix callback errors in retryWithDelay and retry #100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6fce94
Fix callback errors breaking `retryWithDelay`
Cody-Nelson Aug 6, 2024
8477656
Fix callback errors breaking `retry`
Cody-Nelson Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1851,7 +1851,7 @@ function Promise.retry(callback, times, ...)

local args, length = { ... }, select("#", ...)

return Promise.resolve(callback(...)):catch(function(...)
return Promise.try(callback, ...):catch(function(...)
if times > 0 then
return Promise.retry(callback, times - 1, unpack(args, 1, length))
else
Expand Down Expand Up @@ -1880,7 +1880,7 @@ function Promise.retryWithDelay(callback, times, seconds, ...)

local args, length = { ... }, select("#", ...)

return Promise.resolve(callback(...)):catch(function(...)
return Promise.try(callback, ...):catch(function(...)
if times > 0 then
Promise.delay(seconds):await()

Expand Down