Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Improve usability of world inspect widget #95

Merged
merged 9 commits into from
Jan 3, 2024

Conversation

memorycode
Copy link
Contributor

Includes some minor improvements to the world inspect widget, though larger changes to the debugger are necessary in the future.

  • Default behavior is now to hide intersecting components
  • Component selection now uses a table with headings
  • Size label now shows empty entities, if any
  • Overall width has been reduced by moving things to new rows

The ability to sort components by their count is also included, but there is currently no way to switch to this. Should be included in the future once the Plasma table widget lets you detect header selection.

image

Copy link
Contributor

@benbrimeyer benbrimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some discussion if the Size label (and subsequently the empty entity counter) is even necessary. I feel if we decide to keep the Size label, we should include the empty entity counter since its hard to use the Size label without it. Otherwise if we decide to remove the Size label, we can also ditch the empty entity counter.

lib/debugger/widgets/worldInspect.lua Show resolved Hide resolved
lib/debugger/widgets/worldInspect.lua Show resolved Hide resolved
@memorycode
Copy link
Contributor Author

There was some discussion if the Size label (and subsequently the empty entity counter) is even necessary. I feel if we decide to keep the Size label, we should include the empty entity counter since its hard to use the Size label without it. Otherwise if we decide to remove the Size label, we can also ditch the empty entity counter.

Personally, I think that the number of entities in the world is useful information to have. I think that there are better ways to present this information (and more context that should be included), but those are changes that should be made alongside bigger debugger changes.

@jackTabsCode
Copy link
Collaborator

@memorycode Could you make linting pass? Then I think we should be able to merge this. Nice work!

@memorycode
Copy link
Contributor Author

@memorycode Could you make linting pass? Then I think we should be able to merge this. Nice work!

Should be passing now. Thanks for the reminder :)

As a sidenote, I did the work necessary to support sorting via the table headers here: evaera/plasma#15 (might be a while before a new Plasma release is cut..)

@jackTabsCode jackTabsCode merged commit 643e61b into evaera:main Jan 3, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants