-
-
Notifications
You must be signed in to change notification settings - Fork 31
Improve usability of world inspect widget #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some discussion if the Size label (and subsequently the empty entity counter) is even necessary. I feel if we decide to keep the Size label, we should include the empty entity counter since its hard to use the Size label without it. Otherwise if we decide to remove the Size label, we can also ditch the empty entity counter.
Co-authored-by: benj <[email protected]>
Personally, I think that the number of entities in the world is useful information to have. I think that there are better ways to present this information (and more context that should be included), but those are changes that should be made alongside bigger debugger changes. |
@memorycode Could you make linting pass? Then I think we should be able to merge this. Nice work! |
Should be passing now. Thanks for the reminder :) As a sidenote, I did the work necessary to support sorting via the table headers here: evaera/plasma#15 (might be a while before a new Plasma release is cut..) |
Includes some minor improvements to the world inspect widget, though larger changes to the debugger are necessary in the future.
The ability to sort components by their count is also included, but there is currently no way to switch to this. Should be included in the future once the Plasma table widget lets you detect header selection.