RFC: Switch pac to upstream stm32-rs #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may or may not be the PLL clock. Signed-off-by: Karl Palsson <[email protected]>
Signed-off-by: Karl Palsson <[email protected]>
Fixes: eupn#13 Signed-off-by: Karl Palsson <[email protected]>
No reason to stay on the older package, and easier for other applications to move forwards. Signed-off-by: Karl Palsson <[email protected]>
Fixes: eupn#15 Fixes: 28886ae Signed-off-by: Karl Palsson <[email protected]>
HSE wasn't actually being turned on, so even though the SW bits were set to HSE, the SWS bits never switched over, and we continued running from MSI. Fixes: eupn#16 Signed-off-by: Karl Palsson <[email protected]>
Use the same naming style as the L4 HAL, given that the WB is an L4 with a radio attached. This makes it easier to use l4 example code. Signed-off-by: Karl Palsson <[email protected]>
This is likely to be more maintained going forward. Only changes are due to upstream renaming fields in the SVD to be more standard across families, and to more closely match the RefManuals. Depends on either stm32-rs/stm32-rs#624 or stm32-rs/stm32-rs#473 and then a new upstream pac release, so _this_ commit should change to depend on those, but this shows what's needed and how, for preview. Signed-off-by: Karl Palsson <[email protected]>
Cortex-m-rtic 0.6 supports cortex-m v0.7 by default, but it's not released yet. Signed-off-by: Karl Palsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on my other patch series, and switches to "upstream" stm32-rs pac.
The real change here is all in c1e3a1c
It depends on either stm32-rs/stm32-rs#624 or stm32-rs/stm32-rs#473 so it's only an RFC at the moment. When/If those merge/release, the deps can be properly updated to a real version, instead of me having a local crate source override.
I've tested this with downstream examples from the eupn/stm32wb55 repo (BTLE ibeacon was a quick one) and also some other downstream apps using this hal.
I know this effectively obsoletes a chunk of your own work, and I'm not trying to step on your toes or anything, but it seems like the PAC layer at least could come from the stm32-rs project and get us a lot of work done for free.