Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map images is now a browser view #255

Merged
merged 9 commits into from
Jun 3, 2024
Merged

Map images is now a browser view #255

merged 9 commits into from
Jun 3, 2024

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented May 30, 2024

I copied the code from https://github.com/EU-OSHA/oira.application.buildout/blob/f75c33a3db968bcb1b2ffa68b3ca4a66b396a6d4/scripts/map_images.py and adapted it to work in the context of a view.

The reason is that we want to get rid of that custom buildout, so the code has to be moved.

@ale-rt ale-rt requested a review from reinhardt May 30, 2024 10:02
@ale-rt
Copy link
Member Author

ale-rt commented May 30, 2024

I also tried to check it.
It seems to me it is not working properly.

Maybe the css selectors have to be updated?

Copy link
Contributor

@reinhardt reinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting! I added a few fixes and some more logging. It now works on my local instance.

@reinhardt reinhardt merged commit 9165ede into main Jun 3, 2024
2 checks passed
@reinhardt reinhardt deleted the map-images branch June 3, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants