Add MOTD about duplication #202
Conversation
reinhardt
force-pushed
the
scrum-1137-duplication-motd
branch
from
af145a0
to
fb4cac3
Compare
| ), | ||
| "disabled_key": "call-for-action-banner-disabled", | ||
| }, | ||
| ] |
There was a problem hiding this comment.
Looking at the code, it looks like a dict of dicts would work better:
`duplication-banner` : {...},
`call-for-action-banner` : {...},
This would save you this to cycle over the messages all the time.
E.g.: in [message["disabled_key"] for message in self.all_messages] will become in self.all_messages.
But it looks like also other parts of the code would profit from this
There was a problem hiding this comment.
There are two lines that cycle over the messages like this. One of them is due to the strange situation with the settings. That leaves only one line. I hesitate to restructure the data just for that one line.
There was a problem hiding this comment.
Well as mentioned it is not just that...
There was a problem hiding this comment.
You vaguely mentioned it but did not specify anything else.
I'm reusing NewsletterSetting here although the new setting has nothing to do with the newsletter. I'm also not happy that we have to pass all the known values to query the settings. I'm working on a proposal to improve that (#203).
syslabcom/scrum#1137