Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve extensions for keyUnlockData and createDocumentSettings for built-in implementation #100

Conversation

vkanellopoulos
Copy link
Contributor

Changes:

  • removed secureAreaIdentifier from EudiWallet.getDefaultCreateDocumentSettings extension
  • in DefaultKeyUnlockData check if keyInfo is AndroidKeystoreKeyInfo before creating AndroidKeystoreKeyUnlockData and return keyUnlockData only when key is set for userAuthentication

Closes #98

…EudiWallet.getDefaultCreateDocumentSettings extension; in DefaultKeyUnlockData check if keyInfo is AndroidKeystoreKeyInfo before creating AndroidKeystoreKeyUnlockData
@vkanellopoulos vkanellopoulos force-pushed the fix/android-secure-area-defaults branch from 5de2417 to e12cb32 Compare November 22, 2024 13:04
@vkanellopoulos vkanellopoulos merged commit 1bdcdea into eu-digital-identity-wallet:main Nov 22, 2024
3 checks passed
@vkanellopoulos vkanellopoulos deleted the fix/android-secure-area-defaults branch November 22, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DocumentExtensions DefaultKeyUnlockData and getDefaultCreateDocumentSettings
2 participants