Update according to ARF 1.2 (sample data, tests, strings.xml updated)

eu-digital-identity-wallet · Nov 24, 2023 · f80ead2 · f80ead2
1 parent 97be7a2
commit f80ead2
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 16 deletions.
diff --git a/wallet-core/src/main/res/values/strings.xml b/wallet-core/src/main/res/values/strings.xml
@@ -18,7 +18,6 @@
 
     <!-- EU PID -->
     <string name="eu_pid_doctype_name">EU PID</string>
-    <string name="unique_id">Unique identifier</string>
     <string name="persistent_id">Persistent Identifier</string>
     <string name="family_name_birth">Family Name at Birth</string>
     <string name="first_name_birth">First Name at Birth</string>

diff --git a/wallet-core/src/test/assets/sample_data.json b/wallet-core/src/test/assets/sample_data.json
diff --git a/wallet-core/src/test/java/eu/europa/ec/eudi/wallet/documentsTest/PIDAllFieldsTest.kt b/wallet-core/src/test/java/eu/europa/ec/eudi/wallet/documentsTest/PIDAllFieldsTest.kt
@@ -52,7 +52,6 @@ import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.RESIDENT_HOUSE_NUMB
 import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.RESIDENT_POSTAL_CODE
 import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.RESIDENT_STATE
 import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.RESIDENT_STREET
-import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.UNIQUE_ID
 import org.junit.Before
 import org.junit.Test
 
@@ -78,11 +77,6 @@ class PIDAllFieldsTest : BaseTest() {
         testPIDField(BIRTH_DATE)
     }
 
-    @Test
-    fun `unique_id is valid`() {
-        testPIDField(UNIQUE_ID)
-    }
-
     @Test
     fun `family_name_birth is valid`() {
         testPIDField(FAMILY_NAME_BIRTH)

diff --git a/wallet-core/src/test/java/eu/europa/ec/eudi/wallet/documentsTest/PIDMandatoryFieldsTest.kt b/wallet-core/src/test/java/eu/europa/ec/eudi/wallet/documentsTest/PIDMandatoryFieldsTest.kt
@@ -24,7 +24,6 @@ import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.GIVEN_NAME
 import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.ISSUANCE_DATE
 import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.ISSUING_AUTHORITY
 import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.ISSUING_COUNTRY
-import eu.europa.ec.eudi.wallet.documentsTest.util.Constants.UNIQUE_ID
 import org.junit.Before
 import org.junit.Test
 
@@ -50,11 +49,6 @@ class  PIDMandatoryFieldsTest : BaseTest() {
         testFullDatePIDField(BIRTH_DATE)
     }
 
-    @Test
-    fun `unique_id is valid`() {
-        testTstrOrBstrPIDField(UNIQUE_ID)
-    }
-
     @Test
     fun `issue_date is valid`() {
         testTDateOrFullDatePIDField(ISSUANCE_DATE)

diff --git a/wallet-core/src/test/java/eu/europa/ec/eudi/wallet/documentsTest/util/Constants.kt b/wallet-core/src/test/java/eu/europa/ec/eudi/wallet/documentsTest/util/Constants.kt
@@ -45,7 +45,6 @@ object Constants {
     const val AGE_OVER_60 = "age_over_60"
     const val AGE_OVER_65 = "age_over_65"
     const val AGE_OVER_68 = "age_over_68"
-    const val UNIQUE_ID = "unique_id"
     const val FAMILY_NAME_BIRTH = "family_name_birth"
     const val GIVEN_NAME_BIRTH = "given_name_birth"
     const val GENDER = "gender"
@@ -60,7 +59,7 @@ object Constants {
     )
 
     val PID_MANDATORY_FIELDS = arrayOf(
-        FAMILY_NAME, GIVEN_NAME, BIRTH_DATE, UNIQUE_ID, ISSUANCE_DATE, EXPIRY_DATE,
+        FAMILY_NAME, GIVEN_NAME, BIRTH_DATE, ISSUANCE_DATE, EXPIRY_DATE,
         ISSUING_AUTHORITY, ISSUING_COUNTRY
     )