Add null checks to clear warning from IntelliJ

etsy · Jan 7, 2016 · 53b0097 · 53b0097
1 parent 8ef1ddf
commit 53b0097
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/main/java/com/etsy/arbiter/OozieWorkflowGenerator.java b/src/main/java/com/etsy/arbiter/OozieWorkflowGenerator.java
@@ -122,6 +122,9 @@ public void generateOozieWorkflows(String outputBase, List<Workflow> workflows,
                 Action transition = getTransition(workflowGraph, a);
                 switch (a.getType()) {
                     case "start":
+                        if (transition == null) {
+                            throw new RuntimeException("No transition found for start action");
+                        }
                         directives.add("start")
                                 .attr("to", transition.getName())
                                 .up();
@@ -141,6 +144,9 @@ public void generateOozieWorkflows(String outputBase, List<Workflow> workflows,
                         directives.up();
                         break;
                     case "join":
+                        if (transition == null) {
+                            throw new RuntimeException(String.format("No transition found for join action %s", a.getName()));
+                        }
                         directives.add("join")
                                 .attr("name", a.getName())
                                 .attr("to", transition.getName())