-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish v5.1.0 #686
base: master
Are you sure you want to change the base?
Publish v5.1.0 #686
Conversation
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.19.2...4.20.0) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…orkflow/express-4.20.0 Bump express from 4.19.2 to 4.20.0 in /login-workflow
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.4.7 to 2.5.4. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@2.4.7...2.5.4) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.20.2...1.20.3) --- updated-dependencies: - dependency-name: body-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.19.2...4.21.0) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…orkflow/dompurify-2.5.4 Bump dompurify from 2.4.7 to 2.5.4 in /login-workflow
…orkflow/body-parser-1.20.3 Bump body-parser from 1.20.2 to 1.20.3 in /login-workflow
…orkflow/example/express-4.21.0 Bump express from 4.19.2 to 4.21.0 in /login-workflow/example
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.19.2...4.21.0) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…orkflow/example-vite/express-4.21.0 Bump express from 4.19.2 to 4.21.0 in /login-workflow/example-vite
Bumps [rollup](https://github.com/rollup/rollup) from 2.79.1 to 2.79.2. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.79.1...v2.79.2) --- updated-dependencies: - dependency-name: rollup dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [basic-auth-connect](https://github.com/expressjs/basic-auth-connect) from 1.0.0 to 1.1.0. - [Release notes](https://github.com/expressjs/basic-auth-connect/releases) - [Commits](expressjs/basic-auth-connect@1.0.0...1.1.0) --- updated-dependencies: - dependency-name: basic-auth-connect dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 4.6.0 to 4.6.2. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) --- updated-dependencies: - dependency-name: eslint-plugin-react-hooks dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.39 to 18.3.10. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…orkflow/example/dev/types/react-18.3.10 Bump @types/react from 18.2.39 to 18.3.10 in /login-workflow/example
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.4.7 to 2.5.7. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@2.4.7...2.5.7) --- updated-dependencies: - dependency-name: dompurify dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…orkflow/example-vite/dompurify-2.5.7 Bump dompurify from 2.4.7 to 2.5.7 in /login-workflow/example-vite
…orkflow/example/rollup-2.79.2 Bump rollup from 2.79.1 to 2.79.2 in /login-workflow/example
…orkflow/dev/eslint-plugin-react-hooks-4.6.2 Bump eslint-plugin-react-hooks from 4.6.0 to 4.6.2 in /login-workflow
…orkflow/basic-auth-connect-1.1.0 Bump basic-auth-connect from 1.0.0 to 1.1.0 in /login-workflow
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.6 to 2.0.7. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.7/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.6...v2.0.7) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…orkflow/example/http-proxy-middleware-2.0.7 Bump http-proxy-middleware from 2.0.6 to 2.0.7 in /login-workflow/example
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.6 to 2.0.7. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.7/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.6...v2.0.7) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…orkflow/example-vite/http-proxy-middleware-2.0.7 Bump http-proxy-middleware from 2.0.6 to 2.0.7 in /login-workflow/example-vite
Bumps [babel-plugin-istanbul](https://github.com/istanbuljs/babel-plugin-istanbul) from 6.1.1 to 7.0.0. - [Release notes](https://github.com/istanbuljs/babel-plugin-istanbul/releases) - [Changelog](https://github.com/istanbuljs/babel-plugin-istanbul/blob/master/CHANGELOG.md) - [Commits](istanbuljs/babel-plugin-istanbul@v6.1.1...v7.0.0) --- updated-dependencies: - dependency-name: babel-plugin-istanbul dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [dompurify](https://github.com/cure53/DOMPurify) and [@types/dompurify](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/dompurify). These dependencies needed to be updated together. Updates `dompurify` from 2.5.4 to 3.1.7 - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@2.5.4...3.1.7) Updates `@types/dompurify` from 2.4.0 to 3.0.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/dompurify) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/dompurify" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…orkflow/example/dev/babel-plugin-istanbul-7.0.0 Bump babel-plugin-istanbul from 6.1.1 to 7.0.0 in /login-workflow/example
…orkflow/dev/multi-9ae4d6a977 Bump dompurify and @types/dompurify in /login-workflow
Firebase deploy on pull request
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…orkflow/example-vite/nanoid-3.3.8 Bump nanoid from 3.3.7 to 3.3.8 in /login-workflow/example-vite
Release/mui v6 to dev merge
Thank you for the master pull request. 👍 Please be sure this pull request is for the master branch. The master branch is used for items that are ready for publishing. The dev branch is our working branch for all issues and enhancements. Please read our Contributing Guidelines for more information. |
Package version changed
Visit the preview URL for this PR (updated for commit bca9a6b): https://blui-react-login--pr686-dev-uw33hxo2.web.app (expires Sun, 22 Dec 2024 17:35:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
"@mui/icons-material": "^5.10.15", | ||
"@mui/material": "^5.10.15", | ||
"@mui/icons-material": "^6.1.4", | ||
"@mui/material": "^6.1.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New peer dependencies means this needs to be a new major version of the workflow, not a minor
|
||
### Changed | ||
|
||
- Updated styles to use the new MUI 6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to also mention the new peer dependency requirements
@@ -66,6 +66,15 @@ In short, you will need to: | |||
- [Components & APIs](https://github.com/etn-ccis/blui-react-workflows/tree/master/login-workflow/docs/components/README.md) | |||
- [Screens](https://github.com/etn-ccis/blui-react-workflows/tree/master/login-workflow/docs/screens/README.md) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a migration section for going to version 6 (if the styling stuff doesn't need any changes it should be a simple as notating the new peer dependency updates).
@@ -0,0 +1,77 @@ | |||
# Using the Theme in your Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We moved this to the theme package right? It seems out of place here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this theme doc need moved to different repo or just remove?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 72.64% 74.77% +2.12%
==========================================
Files 89 89
Lines 1126 1090 -36
Branches 247 206 -41
==========================================
- Hits 818 815 -3
- Misses 130 131 +1
+ Partials 178 144 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes # .
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?