Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase deploy on pull request #679

Merged
merged 8 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/firebase-hosting-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,24 @@
# https://github.com/firebase/firebase-tools

name: Deploy to Firebase Hosting on merge
'on':
push:
branches:
- master
on:
push:
branches:
- master

permissions:
pull-requests: write
contents: read
checks: write

jobs:
build_and_deploy:
runs-on: ubuntu-latest
env:
OKTA_APP_ISSUER: ${{secrets.OKTA_APP_ISSUER}}
steps:
- uses: actions/checkout@v2
- run: cd login-workflow && yarn install:dependencies && yarn link:workflow && cd example && yarn && yarn build
- uses: actions/checkout@v4
- run: cd login-workflow && yarn install:dependencies && yarn link:workflow && cd example && yarn && echo "${{ secrets.OKTA_APP_ISSUER }}" > .env.local && yarn build
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
entryPoint: './login-workflow'
Expand Down
15 changes: 12 additions & 3 deletions .github/workflows/firebase-hosting-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,23 @@
# https://github.com/firebase/firebase-tools

name: Deploy to Firebase Hosting on PR
'on': pull_request

on: pull_request

permissions:
pull-requests: write
contents: read
checks: write

jobs:
build_and_preview:
if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}'
runs-on: ubuntu-latest
env:
OKTA_APP_ISSUER: ${{secrets.OKTA_APP_ISSUER}}
steps:
- uses: actions/checkout@v2
- run: cd login-workflow && yarn install:dependencies && yarn link:workflow && cd example && yarn && yarn build
- uses: actions/checkout@v4
- run: cd login-workflow && yarn install:dependencies && yarn link:workflow && cd example && yarn && echo "${{ secrets.OKTA_APP_ISSUER }}" > .env.local && yarn build
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
entryPoint: './login-workflow'
Expand Down
24 changes: 14 additions & 10 deletions login-workflow/firebase.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"hosting": {
"public": "example/build",
"ignore": ["firebase.json", "**/.*", "**/node_modules/**"],
"rewrites": [
{
"source": "**",
"destination": "/index.html"
}
]
}
"hosting": {
"public": "example/build",
"ignore": [
"firebase.json",
"**/.*",
"**/node_modules/**"
],
"rewrites": [
{
"source": "**",
"destination": "/index.html"
}
]
}
}
Loading