Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated components to use css variables #675

Merged

Conversation

surajeaton
Copy link
Collaborator

Fixes # BLUI-6190

Changes proposed in this Pull Request:

  • Updated package dependecies to use mui v6, components, themes
  • Updated components to use theme mode utility

Screenshots / Screen Recording (if applicable)

To Test:

  • cd login-workflow
  • yarn start:example

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.58%. Comparing base (978cee8) to head (89cb444).
Report is 2 commits behind head on release/mui-v6.

Files with missing lines Patch % Lines
...kflow/src/components/WorkflowCard/WorkflowCard.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/mui-v6     #675      +/-   ##
==================================================
- Coverage           72.67%   72.58%   -0.09%     
==================================================
  Files                  89       89              
  Lines                1127     1127              
  Branches              246      246              
==================================================
- Hits                  819      818       -1     
  Misses                131      131              
- Partials              177      178       +1     
Flag Coverage Δ
unittests 72.58% <50.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffGreiner-eaton
Copy link
Collaborator

JeffGreiner-eaton commented Dec 4, 2024

the build is failing locally and in CI, the dompurify package was updated a couple days ago.
image

I updated dependencies and the build works locally but not sure if this is what we want...
image

@surajeaton
Copy link
Collaborator Author

the build is failing locally and in CI, the dompurify package was updated a couple days ago. image

I updated dependencies and the build works locally but not sure if this is what we want... image

Reverted to previous versions. Please review.

Copy link

github-actions bot commented Dec 5, 2024

Visit the preview URL for this PR (updated for commit e5f4bf1):

https://blui-react-login--pr675-feature-6190-update-75rdqzol.web.app

(expires Sat, 07 Dec 2024 07:14:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@surajeaton surajeaton merged commit 3090bbd into release/mui-v6 Dec 5, 2024
3 checks passed
@surajeaton surajeaton deleted the feature/6190-update-components-to-use-css-variables branch December 5, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

3 participants