Fixed change passsword dialog onclose

[surajeaton]

Fixes # BLUI-6323 #656

Changes proposed in this Pull Request:

• Fixed change passsword error dialog onclose

Screenshots / Screen Recording (if applicable)

Screen.Recording.2024-11-19.at.6.02.40.PM.mov

To Test:

• Update AuthUIActions.tsx changepassword action to throw an error
• Update ChangePassword.tsx in example to:

<ChangePasswordDialog dialogDescription={t('CHANGE_PASSWORD.DESCRIPTION')} open={app.showChangePasswordDialog} onFinish={(): void => { app.setShowChangePasswordDialog(false); }} onPrevious={(): void => { app.setShowChangePasswordDialog(false); }} errorDisplayConfig={{ onClose: (): void => { app.setShowChangePasswordDialog(false); }, }} />

• Login to application
• Click on user menu (top right corner)
• Click on Change Password
• Enter the fields and press Okay

Any specific feedback you are looking for?

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.67%. Comparing base (7beaa4d) to head (10807bf).
Report is 3 commits behind head on dev.

Files with missing lines	Patch %	Lines
...ents/ChangePasswordDialog/ChangePasswordDialog.tsx	33.33%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #667      +/-   ##
==========================================
+ Coverage   72.64%   72.67%   +0.02%     
==========================================
  Files          89       89              
  Lines        1126     1127       +1     
  Branches      247      246       -1     
==========================================
+ Hits          818      819       +1     
- Misses        130      131       +1     
+ Partials      178      177       -1     

Flag	Coverage Δ
unittests	72.67% <33.33%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[JeffGreiner-eaton]

looks good, seems to be working

• Can you update change log for issue fixed.

• If this is to be released as alpha please update package version if adopter team needs it

• also can we update example/src/index to include....

// TODO: Remove this after the issues with @types/react goes away

// https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/68444
/* eslint-disable */
declare global {
    namespace React {
        interface DOMAttributes<T> {
            placeholder?: string | undefined;
            onPointerEnterCapture?: React.PointerEventHandler<T> | undefined;
            onPointerLeaveCapture?: any;
        }
    }
}
/* eslint-disable */

So we can get clean build on example

[surajeaton]

looks good, seems to be working

• Can you update change log for issue fixed.
• If this is to be released as alpha please update package version if adopter team needs it
• also can we update example/src/index to include....

// TODO: Remove this after the issues with @types/react goes away

// https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/68444
/* eslint-disable */
declare global {
    namespace React {
        interface DOMAttributes<T> {
            placeholder?: string | undefined;
            onPointerEnterCapture?: React.PointerEventHandler<T> | undefined;
            onPointerLeaveCapture?: any;
        }
    }
}
/* eslint-disable */

So we can get clean build on example

@JeffGreiner-eaton Done. Please review.

[github-actions]

Visit the preview URL for this PR (updated for commit 10807bf):

https://blui-react-login--pr667-bug-6323-656-fix-cha-hipc2q0a.web.app

_{(expires Sat, 23 Nov 2024 09:33:47 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043}