Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated release date and okta login image in readme #637

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Updated release date and okta login image in readme #637

merged 1 commit into from
Sep 11, 2024

Conversation

surajeaton
Copy link
Collaborator

Fixes # BLUI-6043

Changes proposed in this Pull Request:

-Updated release date in changelog

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 11, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.64%. Comparing base (d78026f) to head (59e8af6).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #637   +/-   ##
=======================================
  Coverage   72.64%   72.64%           
=======================================
  Files          89       89           
  Lines        1126     1126           
  Branches      247      247           
=======================================
  Hits          818      818           
  Misses        130      130           
  Partials      178      178
Flag Coverage Δ
unittests 72.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit 59e8af6):

https://blui-react-login--pr637-feature-update-chang-7zgogwoz.web.app

(expires Fri, 13 Sep 2024 08:00:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@komal-eaton komal-eaton merged commit 90dce07 into dev Sep 11, 2024
14 checks passed
@komal-eaton komal-eaton deleted the feature/update-changelog-release-date branch September 11, 2024 08:05
ektaghag-eaton
ektaghag-eaton reviewed Sep 11, 2024
View reviewed changes
login-workflow/README.md
@@ -18,7 +18,7 @@ This package is flexible, allowing you to use the Login and Registration flows i

These workflows are back-end agnostic, meaning you can use them with any back-end API you wish. You simply need to provide an implementation for several key functions (actions) that are called at various points within the workflows based on user interaction.

![Login](https://raw.githubusercontent.com/etn-ccis/blui-react-workflows/master/login-workflow/media/login.png)
![Login](https://raw.githubusercontent.com/etn-ccis/blui-react-workflows/master/login-workflow/media/okta-login.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surajeaton , Do we need to add [Okta Login] here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes okta login is the recommended login screen, it is better to keep okta login screen shot there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okta Login

Yes okta login is the recommended login screen, it is better to keep okta login screen shot there

Yes, can we rename Login to Okta Login

Suggested change
![Login](https://raw.githubusercontent.com/etn-ccis/blui-react-workflows/master/login-workflow/media/okta-login.png)
![Okta Login](https://raw.githubusercontent.com/etn-ccis/blui-react-workflows/master/login-workflow/media/okta-login.png)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ektaghag-eaton ektaghag-eaton ektaghag-eaton left review comments

@komal-eaton komal-eaton komal-eaton approved these changes

@joebochill joebochill Awaiting requested review from joebochill

@KomalGDhere-eaton KomalGDhere-eaton Awaiting requested review from KomalGDhere-eaton

@JeffGreiner-eaton JeffGreiner-eaton Awaiting requested review from JeffGreiner-eaton JeffGreiner-eaton is a code owner

@manojleaton manojleaton Awaiting requested review from manojleaton

@ArshdeepSingh3-eaton ArshdeepSingh3-eaton Awaiting requested review from ArshdeepSingh3-eaton

@shubham-eaton shubham-eaton Awaiting requested review from shubham-eaton

Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surajeaton @ektaghag-eaton @komal-eaton