Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Basic Dialog from ChangePasswordDialog #621

Merged

Conversation

manojleaton
Copy link
Contributor

Fixes #BLUI-5969 .

Changes proposed in this Pull Request:

  • Fix for the issue
  • Removed BasicDialog code from ChangePasswordDialog since it is no longer needed as error handling is done by ErrorManager.

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.52%. Comparing base (491a282) to head (a11fd22).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #621      +/-   ##
==========================================
+ Coverage   72.44%   72.52%   +0.08%     
==========================================
  Files          86       86              
  Lines        1107     1103       -4     
  Branches      245      245              
==========================================
- Hits          802      800       -2     
+ Misses        126      124       -2     
  Partials      179      179              
Flag Coverage Δ
unittests 72.52% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 12, 2024

Visit the preview URL for this PR (updated for commit a11fd22):

https://blui-react-login--pr621-bug-612-removed-basi-2981lnvi.web.app

(expires Wed, 14 Aug 2024 07:54:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@JeffGreiner-eaton
Copy link
Collaborator

looks good with default error and custom
image

@manojleaton manojleaton merged commit 18f80d1 into dev Aug 19, 2024
11 checks passed
@manojleaton manojleaton deleted the bug/612-removed-basic-dialog-from-change-password-dialog branch August 19, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants